tmodjs icon indicating copy to clipboard operation
tmodjs copied to clipboard

tmod的getConfig方法在获取json的dependencies时的一个bug

Open hwoarangzk opened this issue 9 years ago • 2 comments

if (!json) {

            json = {
                "name": 'template',
                "version": '1.0.0',
                "dependencies": {
                    "tmodjs": "1.0.0"
                },
                "tmodjs-config": {}
            };

        }

        var targetVersion = json.dependencies.tmodjs.replace(/^~/, '');    

这里如果项目本身只有devDependencies而没有dependencies时会出现tmodjs of undefined的错误。建议添加一下容错的逻辑:

if (!json.dependencies) {
    json.dependencies = json.devDependencies;
}

hwoarangzk avatar Oct 09 '15 03:10 hwoarangzk

能否把你的修改 Pull requests ?

aui avatar Oct 09 '15 03:10 aui

@aui 好,稍后我来搞一下

hwoarangzk avatar Oct 09 '15 03:10 hwoarangzk