v8 icon indicating copy to clipboard operation
v8 copied to clipboard

Published 20 hours ago • verified publisher icon augustoroman

grexie/go-v8

Open timoshisa opened this issue 6 years ago • 3 comments

@augustoroman There is a repository in a company which I have now closed which contains an rewrite of your library following the same design patterns you have in your project. Please could you take a look through this repository: grexie/go-v8 and take from it what you think is useful. Please do not attribute copyright to me, it is yours to have.

I had a lot of help from the Lord God in writing the additions I placed in there. He showed me how to write every single line of code.

This code is for you.

timoshisa avatar Feb 14 '19 21:02 timoshisa

What v8 version were you targeting ? You still seem to use v8::V8::CreateSnapshotDataBlob() which has been deprecated in the latest versions.

lacombar avatar Mar 06 '19 07:03 lacombar

I’m sorry, I think you’ve got the wrong GitHub Issue. I don’t recall having worked on snapshots except a little tweaking of function names.

timoshisa avatar Mar 11 '19 04:03 timoshisa

That's very kind, @tbehrsin. I'll keep this issue open for a bit to reference your code as necessary.

augustoroman avatar Apr 18 '19 06:04 augustoroman