vscode-shell-command
vscode-shell-command copied to clipboard
augustocdias
feat: support recursive input lookup
Hi @augustocdias, thank you for creating such great extension, you saved my debugging routine.
One thing I believe could improve the UX a bit in this extension is the ability of recursive input lookup, but I guess that's not a frequently requested feature or no one is working on it, so I created this pull request.
Forgive me, such a large pull request and doing major code refactoring is bad for sure, but I was in a hurry and not fluent in typescript and OOP.
NOTICE the BREAKING change: env option changed from map to array of name value pairs to ensure resolving order
Thank you for the PR. Don't worry because I'm not fluent in typescript either 😅
I'll check it and test next week
About the breaking change. Perhaps we could implement some way to notify users the first time the updated extension is loaded
About the breaking change. Perhaps we could implement some way to notify users the first time the updated extension is loaded
this, I would suggest releasing two versions, one major release with both command shellCommand.execute and extension id renamed to not break existing users, one minor release to notify users that major release with these breaking changes.
That is out of the scope of this pull request, so it's your decision to make.
Another possible solution to the breaking change is to preserve all existing code, add a new command registration, just move code part of this pull request into a separate file and import as a new command.
I like the feature, but I'm not a fan of the refactoring. You basically moved everything to a single file...
You have every right to complain about this, but I could not find any reasonably easy way to not break existing implementation while adding the feature, and after serval failed attempts trying to keep the code object-oriented, I decided to redo it functional, and yes, in a single file, so you can easily checkout the file in another branch and decide otherwise.