ethercalc icon indicating copy to clipboard operation
ethercalc copied to clipboard

Added if for iframe issue in player

Open NexisSis opened this issue 5 years ago • 6 comments

Hey everyone, i'm using ethercalc in iframe (this is the only solution for my project), and i can't do export table, because JavaScript can't get window.parent.location.pathname from iframe. I created a solutions, that check if this window is iframe, and if yes we can open file without window.parent.location.pathname. Also remove unused spaces (my linter :))

NexisSis avatar Jul 17 '20 13:07 NexisSis

It's a little surprising you hit an issue here, the Sandstorm version already works correctly in this regard (EtherCalc is run in an iframe in Sandstorm), unless there's already some sort of fix on the Sandstorm branch specifically.

ocdtrekkie avatar Jul 17 '20 14:07 ocdtrekkie

It's a little surprising you hit an issue here, the Sandstorm version already works correctly in this regard (EtherCalc is run in an iframe in Sandstorm), unless there's already some sort of fix on the Sandstorm branch specifically.

rly?. Check last error :) Cross

NexisSis avatar Jul 20 '20 08:07 NexisSis

Interesting... And you get this when you select the save icon, and select an export format?

I did test before I had responded! Though I do use Firefox, so I am not sure if it's perhaps a browser-specific change that's causing the problem. image

ocdtrekkie avatar Jul 20 '20 13:07 ocdtrekkie

Of course, if it's a problem from your browser, it is probably a problem for many other users too, and so a fix will be important... I was just surprised you hit an issue here. :)

ocdtrekkie avatar Jul 20 '20 13:07 ocdtrekkie

Of course, if it's a problem from your browser, it is probably a problem for many other users too, and so a fix will be important... I was just surprised you hit an issue here. :)

i'm using latest google chrome, so i think it's a big problem for much users

NexisSis avatar Jul 28 '20 13:07 NexisSis

works fine on Chrome for me. The /appeditor options used iframes

http://sheet.cellmaster.com.au/example_button/appeditor

eddyparkinson avatar Oct 16 '20 02:10 eddyparkinson