✨ Audrey ✨
✨ Audrey ✨
👍🏻 Hi @Manolachi, thank you for your contribution! 🤔 Generator output display is a nuanced feature. Your PR doesn't account for issues like passphrases with alphanumeric separators, long passwords, and...
> Can you please clarify what edge-cases you have in mind? I talked to @willmartian and he noted that the changes aren't as extensive as I thought. I'd like this...
Thank you for your contribution @Manolachi!
The icon would be invisible to the screen reader, wouldn't it? ```html {{ "generatorNudgeBodyOne" | i18n }} {{ "generatorIconLabel" | i18n }} {{ "generatorNudgeBodyTwo" | i18n }} ``` If we...
You indicated we should talk offline, so I was letting this PR sit. Is that no longer necessary?
Hi @harr1424! Thank you for drafting support for a deduplication tool! 👍🏻 I'm really excited to help you get your first PR merged! This PR seems to have required a...
>Explore alternative toasts for the situation where no duplicates are found, as the current t oast seems out of place when shown top right corner... That's the correct place for...
@harr1424 - please refrain from force-pushing changes unless absolutely necessary. Altering the commit history makes it difficult to verify the changes you've made since the last review. We squash merge,...