webMUSHRA icon indicating copy to clipboard operation
webMUSHRA copied to clipboard

Published 20 hours ago • verified publisher icon audiolabs

Preference test

Open Simon-Stone opened this issue 2 years ago • 5 comments

DISCLAIMER: I am by no means a JavaScript programmer and I have cannibalized various other pages to clobber the new page together. I am absolutely certain that there the code could use some refactoring and cleanup, but I unfortunately do not have access to any experienced JavaScript programmers. If someone would take the time to do a proper code review of this PR, I would be happy to make any required changes, though.

I have a particular use case that was not covered by the current framework: I want to compare a list different stimuli amongst itself in pairwise fashion. There is no reference or baseline, I simply want to compare every stimulus against every other stimulus and ask the subject which one they prefer. I also want to run the experiment online, possibly using crowdsourced participants, which means I need a way to discern who actually completed the experiment.

This PR adds several things to support this use case:

  • a new page preference_test,
  • the option to generate a random subject ID every time results are written,
  • the option to display a confirmation code on the final popup page after the results are written.

All new features are documented in experimenter.md and participant.md. Two new YAML files pref.yaml and pref_grouped.yaml are added to configs/ to illustrate the use of the new page and options.

Closes #88

Simon-Stone avatar May 31 '22 15:05 Simon-Stone

@nullpunktTUD this is awesome. Thanks! I won't have time to review this before end of June. There are some javascript linter that could detect some errors maybe run this before...

faroit avatar May 31 '22 18:05 faroit

As I said, I won't be able to provide a full review but this looks already quite good to me. @nullpunktTUD is there things missing? Otherwise I would give this a test and if things work as advertised, we can merge this.

Please also see my minor comments

Thank you for taking the time to consider the PR!

I don't think there is anything missing and it seems to be working just fine.

I'll try to resolve all your minor comments soon.

Simon-Stone avatar Jul 06 '22 06:07 Simon-Stone

Are there any changes left for me to make?

Simon-Stone avatar Aug 02 '22 12:08 Simon-Stone

Will look at this again end of the week

faroit avatar Aug 02 '22 14:08 faroit

this would be a super useful PR 😄

@nullpunktTUD Looks like you should add the pref test to configs/complete.yaml as well

JRMeyer avatar Aug 09 '22 00:08 JRMeyer