webMUSHRA icon indicating copy to clipboard operation
webMUSHRA copied to clipboard

Published 20 hours ago • verified publisher icon audiolabs

Spacebar Play/Pause doesn't work correctly on Firefox 88.0.1

Open tjueterb opened this issue 3 years ago • 3 comments

Hey guys,

play/pause gets triggered when pressing and when releasing the spacebar on Firefox 88.0.1

I didn't notice the issue on other browsers.

tjueterb avatar Jun 01 '21 12:06 tjueterb

probably some issue with the keyboard shortcut lib we are using. the version inside webMUSHRA seems horribly outdated: https://github.com/ccampbell/mousetrap

I don't have the bandwidth to change this right now, but feel free to open a PR, replacing https://github.com/audiolabs/webMUSHRA/tree/master/lib/external/mousetrap with the newest version and test if this solves it...

faroit avatar Jun 01 '21 13:06 faroit

I replaced both files (LICENSE.txt and mousetrap.min.js) with the updated versions but it did not solve the issue for me, do you still want me to open a PR?

tjueterb avatar Jun 01 '21 14:06 tjueterb

@tjueterb Lets maybe wait until the issue is fixed. Can you raise an issue at mousetrap or try to reproduce it in a demo site?

faroit avatar Jun 03 '21 10:06 faroit