StereoIntensityShort doesnt seem to do anything

Open audioboy77 opened this issue 8 years ago • 2 comments

Code seems to nothing (except truncate the values)

Sep 19 '17 00:09 audioboy77

May be related, we found StereoIntensityLong was going out of bounds when is_pos > 7. The go implementation has a simple fix here https://github.com/hajimehoshi/go-mp3/issues/24

Mar 20 '18 22:03 BeamdogZach

The out of bounds issue was already fixed in OpenMP3. The issue is rather that the code only seems to round the input, due to some float -> int -> float conversion. Im sceptical this was the original intention of the code, and that the PDMP3 author made a mistake. If someone has an mp3 which uses this routine, then please send it to me.

Mar 28 '18 09:03 audioboy77