audacity icon indicating copy to clipboard operation
audacity copied to clipboard

5901 overflow button

Open saintmatthieu opened this issue 1 year ago • 8 comments

Resolves: #5901

  • [x] I signed CLA
  • [x] The title of the pull request describes an issue it addresses
  • [x] If changes are extensive, then there is a sequence of easily reviewable commits
  • [x] Each commit's message describes its purpose and effects
  • [x] There are no behavior changes unnecessary for the stated purpose of the PR

Recommended:

  • [x] Each commit compiles and runs on my machine without known undesirable changes of behavior

QA:

  • [ ] See if by chances it fixes #5959 (not mandatory)

saintmatthieu avatar Feb 13 '24 17:02 saintmatthieu

The build fails, in both commits.

Remember -Daudacity_use_pch=NO in your Cmake variables.

Paul-Licameli avatar Feb 14 '24 20:02 Paul-Licameli

I fix the build, try to run it, generate noise -- and there is a crash.

Paul-Licameli avatar Feb 14 '24 21:02 Paul-Licameli

So it was at least in a debug build.

Paul-Licameli avatar Feb 14 '24 21:02 Paul-Licameli

@Paul-Licameli thanks for your comments and help, I just pushed fixes. I moved back this ticket to the progress column because of https://github.com/audacity/audacity/pull/5952#discussion_r1489495326.

saintmatthieu avatar Feb 15 '24 08:02 saintmatthieu

The CI builds still fail

Paul-Licameli avatar Feb 15 '24 10:02 Paul-Licameli

The build is still failing

Paul-Licameli avatar Feb 15 '24 13:02 Paul-Licameli

You still need <wx/frame.h> in WaveClipUtilities

Paul-Licameli avatar Feb 15 '24 13:02 Paul-Licameli

And the last commit causes new compilation errors

Paul-Licameli avatar Feb 15 '24 13:02 Paul-Licameli

image

https://github.com/audacity/audacity/issues/5959 this has not been fixed by this PR. The issue is still present on Linux.

chinakov avatar Feb 22 '24 14:02 chinakov