audacity
audacity copied to clipboard
5901 overflow button
Resolves: #5901
- [x] I signed CLA
- [x] The title of the pull request describes an issue it addresses
- [x] If changes are extensive, then there is a sequence of easily reviewable commits
- [x] Each commit's message describes its purpose and effects
- [x] There are no behavior changes unnecessary for the stated purpose of the PR
Recommended:
- [x] Each commit compiles and runs on my machine without known undesirable changes of behavior
QA:
- [ ] See if by chances it fixes #5959 (not mandatory)
The build fails, in both commits.
Remember -Daudacity_use_pch=NO
in your Cmake variables.
I fix the build, try to run it, generate noise -- and there is a crash.
So it was at least in a debug build.
@Paul-Licameli thanks for your comments and help, I just pushed fixes. I moved back this ticket to the progress column because of https://github.com/audacity/audacity/pull/5952#discussion_r1489495326.
The CI builds still fail
The build is still failing
You still need <wx/frame.h>
in WaveClipUtilities
And the last commit causes new compilation errors
https://github.com/audacity/audacity/issues/5959 this has not been fixed by this PR. The issue is still present on Linux.