sddf icon indicating copy to clipboard operation
sddf copied to clipboard

matching design doc on blk and its code

Open erichchan999 opened this issue 1 year ago • 1 comments

Currently the design document for storage devices in Listing 5.1 does not match the code. These need to be changed:

  • removing count and address fields in blk_response. These were included to simplify the bookkeeping process, and as we implement the various blk components have found them unneccessary.
  • QUEUE_SIZE is defined separately for both queues -> BLK_REQ_QUEUE_SIZE, BLK_RESP_QUEUE_SIZE
  • The response enum is called a response_status, and is defined separately from the response struct

In Listing 5.2 outlining blk storage information fields:

  • an additional sector_size field is added to communicate the minimum blocksize, this may be smaller than the transfer size and will require a different implementation.
  • blocksize renamed to block_size for consistency
  • additional comments

erichchan999 avatar Mar 27 '24 01:03 erichchan999

Also, the head and tail indices seem to be reversed compared to the network queue.

Ivan-Velickovic avatar May 14 '24 05:05 Ivan-Velickovic