google-translate icon indicating copy to clipboard operation
google-translate copied to clipboard

defstruct or maybe cl-defstruct

Open tomnor opened this issue 4 years ago • 2 comments

Hello Translation hackers

After some package updates and removals, I got an error about `defstruct' being unknown. The following hack got rid of that

diff --git a/google-translate-core-ui.el b/google-translate-core-ui.el
index 2bc4af5..a224f06 100644
--- a/google-translate-core-ui.el
+++ b/google-translate-core-ui.el
@@ -288,2 +288,2 @@ query parameter in HTTP requests.")
 (defvar google-translate-translation-listening-debug nil
   "For debug translation listening purposes.")

-(defstruct gtos
+(cl-defstruct gtos
   "google translate output structure contains miscellaneous
   information which intended to be outputed to the buffer, echo
   area or popup tooltip."

I think defstruct is obsolete but maybe you use that for some backwards reason?

tomnor avatar Jul 05 '20 16:07 tomnor

Symbol's function definition is void: defstruct

velkyel avatar Jul 10 '20 06:07 velkyel

also need to fix:

  1. loop --> cl-loop
  2. incf --> cl-incf

leuven65 avatar Jul 12 '20 09:07 leuven65