AContent icon indicating copy to clipboard operation
AContent copied to clipboard

Published 20 hours ago • verified publisher icon atutor

Issue 4875: Import from URL not working

Open iam-TJ opened this issue 13 years ago • 6 comments

See http://atutor.ca/atutor/mantis/view.php?id=4875

iam-TJ avatar Oct 25 '11 20:10 iam-TJ

I tried using the branch but it gave me a blank page after import. Seems to be caused by the newlines at EOF in both files. You don't need to make another pull request, this should update itself, I will merge it afterwards, thanks!

harriswong avatar Oct 27 '11 15:10 harriswong

Hi TJ, thanks for the great contribution. Totally awesome!

Regarding harris' comment on this pull request, I don't see any new commit attempting to resolve it. Let me know if any help you need. Thanks.

cindyli avatar Nov 02 '11 15:11 cindyli

Me neither; Harris, can you revisit this please?

iam-TJ avatar Nov 05 '11 08:11 iam-TJ

Sure would you like me to change that for you? You can also remove those on your branch, and push it to your github origin, it will automatically reflects the changes here.

harriswong avatar Nov 05 '11 21:11 harriswong

You're referring to the "newlines at EOF" you mentioned earlier? I haven't experienced that issue at all - what platform are you testing on?

iam-TJ avatar Nov 06 '11 21:11 iam-TJ

Hi, I was doing this on my macbookpro platform, via pull from your branch as a remote. Here is the line that have some newline: https://github.com/iam-TJ/AContent/blob/d09c6421f8293c7d6d2ec5d5a97ec51cbc8f6947/include/classes/HTTPRequest.class.php#L134-135

harriswong avatar Nov 06 '11 22:11 harriswong