UnitConversion icon indicating copy to clipboard operation
UnitConversion copied to clipboard

Converting between units which do not (or not only) have just a factor

Open rohitjha opened this issue 7 years ago • 5 comments

Currently we only support conversion between units of the form: left = right * factor. However, for temperature conversion, the units such as Celsius, Fahrenheit and Kelvin are not convertible by multiplication with factors.

rohitjha avatar Nov 05 '17 02:11 rohitjha

Noted. 👍

I'm planning of incorporating a Temperature "module" later on, after I'm done with setting the codebase along with standards implemented in stylecop. Of course, you're more than welcome to give it a try after I set up the codebase. :)

gkampolis avatar Feb 10 '18 14:02 gkampolis

Sounds good, I'll give it a shot then. :+1:

rohitjha avatar Feb 15 '18 03:02 rohitjha

@rohitjha Just make sure you 're-fork' the repo so you'll have the latest changes to the codebase, otherwise it won't be easy to merge your pull request. :)

gkampolis avatar Feb 15 '18 14:02 gkampolis

:+1:

rohitjha avatar Feb 15 '18 14:02 rohitjha

I had my own go with a more generic conversion function to support temperature conversions and more. Unfortunately it would be a breaking change to the existing code base. Check out my fork to see it.

MarkusKgit avatar Mar 07 '18 10:03 MarkusKgit