atuin icon indicating copy to clipboard operation
atuin copied to clipboard

Add "filter_mode_list" configuration option

Open matthiasbeyer opened this issue 1 year ago • 5 comments

Closes #1654 Maybe closes #366

Checks

  • [x] I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • [x] I have checked that there are no existing pull requests for the same thing

matthiasbeyer avatar Jan 30 '24 10:01 matthiasbeyer

I did not yet test-drive this (also because I ran into #1653 while I started working on this).

I leave the discussion whether such a feature is desired to the issue (#1654 ) :+1:

matthiasbeyer avatar Jan 30 '24 10:01 matthiasbeyer

Also, this feature somewhat contradicts the filter_mode setting I guess, because implicitly the first entry in the filter_modes_list is the default, right? :thinking: We might want to have some discussion about this as well.

matthiasbeyer avatar Jan 30 '24 11:01 matthiasbeyer

Any ideas about this?

matthiasbeyer avatar Feb 10 '24 17:02 matthiasbeyer

I think it would make sense to add a [search] block

So

[search]
filters = ["session", "directory", "global"]

When set, it will override filter_mode and any other related settings.

Wrt workspaces, I'd suggest the following

  1. If a filter list is set, does not contain workspace, and workspaces = true. We should work with the current behaviour, of switching to workspace mode.
  2. If a filter list is set, and does contain workspace, then follow the order set in the list - regardless of whether workspaces = true.

ellie avatar Feb 12 '24 09:02 ellie

I'd love to see this feature!

mattbaker avatar Feb 22 '24 01:02 mattbaker