atuin
atuin copied to clipboard
Add "filter_mode_list" configuration option
Closes #1654 Maybe closes #366
Checks
- [x] I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
- [x] I have checked that there are no existing pull requests for the same thing
I did not yet test-drive this (also because I ran into #1653 while I started working on this).
I leave the discussion whether such a feature is desired to the issue (#1654 ) :+1:
Also, this feature somewhat contradicts the filter_mode
setting I guess, because implicitly the first entry in the filter_modes_list
is the default, right? :thinking: We might want to have some discussion about this as well.
Any ideas about this?
I think it would make sense to add a [search]
block
So
[search]
filters = ["session", "directory", "global"]
When set, it will override filter_mode
and any other related settings.
Wrt workspaces, I'd suggest the following
- If a filter list is set, does not contain workspace, and workspaces = true. We should work with the current behaviour, of switching to workspace mode.
- If a filter list is set, and does contain workspace, then follow the order set in the list - regardless of whether workspaces = true.
I'd love to see this feature!