mmpy_bot icon indicating copy to clipboard operation
mmpy_bot copied to clipboard

Published 20 hours ago • verified publisher icon attzonko

Check Python 3.10

Open attzonko opened this issue 2 years ago • 4 comments

Checking if any issues are going to show in 3.10

attzonko avatar Jun 18 '22 18:06 attzonko

The failure in this issue is caused by the same as #319 Should be safe to merge once the other is fixed.

unode avatar Jul 15 '22 18:07 unode

The failure in this issue is caused by the same as #319 Should be safe to merge once the other is fixed.

I agree, but I am not coming up with a simple fix. And I don't want to disable the typing check...

attzonko avatar Jul 20 '22 07:07 attzonko

I will give it a shot later today. I think the solution is to add default (= None) values to the base Function class or create a Union type for those arguments. There are some attributes that are only available in click_functions and the type-checking is being done against a more generic Callable type.

unode avatar Jul 20 '22 14:07 unode

@unode Not the cleanest but I think it should work. Thoughts?

attzonko avatar Aug 18 '22 15:08 attzonko

Code Climate has analyzed commit 1e94d5c1 and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot] avatar Aug 21 '22 19:08 codeclimate[bot]