vscode-mjml
vscode-mjml copied to clipboard
Remote images take really long time to render in the preview
The issue wasn't reported before AFAIK
Expected behavior
The expected behavior is to render the images as fast as the text content is rendered (or with a short delay)
Actual behavior
When I open the preview for the first time, the images in the email take really long to render, maybe 25-30 seconds, after the text.
If loading the images separately our viewing them from the browser, it's almost instant, like I would expect it.
Steps to reproduce the problem
- Open visual studio
- Wait for it to load completely
- Copy an MJML template's code
- Create a new file, add .mjml extension in file name and paste the code
- Type "F1" then "Preview email"
- See the preview has only the text (Image are not loaded)
- Wait many seconds, and see the image displayed
Code sample
I reproduced the test with an official MJML template
<mjml>
<mj-body background-color="#F4F4F4" color="#55575d" font-family="Arial, sans-serif">
<mj-section background-color="#000000" background-repeat="no-repeat" text-align="center" vertical-align="top">
<mj-column>
<mj-image align="center" border="none" padding-bottom="30px" padding="10px 25px" src="http://5vph.mj.am/img/5vph/b/1g86w/0g67t.png" target="_blank" title="" width="180px"></mj-image>
<mj-text align="left" color="#55575d" font-family="Arial, sans-serif" font-size="13px" line-height="22px" padding-bottom="0px" padding-top="0px" padding="10px 25px">
<p style="line-height: 18px; margin: 10px 0; text-align: center;font-size:14px;color:#ffffff;font-family:'Times New Roman',Helvetica,Arial,sans-serif">WOMEN | MEN | KIDS</p>
</mj-text>
</mj-column>
</mj-section>
<mj-section background-color="#000000" background-repeat="no-repeat" text-align="center" vertical-align="top" padding="0 0 0 0">
<mj-column>
<mj-image align="center" border="none" padding-bottom="0px" padding-left="0px" padding-right="0px" padding="0px 25px" src="http://5vph.mj.am/img/5vph/b/1g86w/0696u.jpeg" target="_blank" title="" width="780px"></mj-image>
</mj-column>
</mj-section>
<mj-section background-color="#000000" background-repeat="no-repeat" text-align="center" vertical-align="top" padding="0 0 0 0">
<mj-column>
<mj-text align="left" color="#55575d" font-family="Arial, sans-serif" font-size="13px" line-height="22px" padding-bottom="5px" padding-top="25px" padding="10px 25px">
<p style="line-height: 60px; text-align: center; margin: 10px 0;font-size:55px;color:#fcfcfc;font-family:'Times New Roman',Helvetica,Arial,sans-serif"><b>Black Friday</b></p>
</mj-text>
<mj-text align="left" color="#55575d" font-family="Arial, sans-serif" font-size="13px" line-height="22px" padding-bottom="20px" padding-top="0px" padding="10px 25px">
<p style="line-height: 30px; text-align: center; margin: 10px 0;color:#f5f5f5;font-size:25px;font-family:'Times New Roman',Helvetica,Arial,sans-serif"><b>Take an extra 50% off</b><br/><span style="color:#ffffff;font-size:18px;font-family:'Times New Roman',Helvetica,Arial,sans-serif">Use code SALEONSALE* at checkout</span></p>
</mj-text>
</mj-column>
</mj-section>
<mj-section background-color="#000000" background-repeat="no-repeat" text-align="center" vertical-align="top" padding-bottom="40px" padding="0 0 0 0">
<mj-column>
<mj-button background-color="#ffffff" border-radius="3px" font-family="Times New Roman, Helvetica, Arial, sans-serif" font-size="18px" font-weight="normal" inner-padding="10px 25px" padding-bottom="30px" padding="10px 25px"><span style="color:#212020">Shop Now</span></mj-button>
<mj-text align="left" color="#55575d" font-family="Arial, sans-serif" font-size="13px" line-height="22px" padding-bottom="0px" padding-top="5px" padding="10px 25px">
<p style="line-height: 16px; text-align: center; margin: 10px 0;font-size:12px;color:#ffffff;font-family:'Times New Roman',Helvetica,Arial,sans-serif">* Offer valid on Allura purchases on 17/29/11 at 11:59 pm. No price adjustments on previous <br/><span style="color:#ffffff;font-family:'Times New Roman',Helvetica,Arial,sans-serif">purchases, offer limited to stock. Cannot be combined with any offer or promotion other than free.</span></p>
</mj-text>
</mj-column>
</mj-section>
</mj-body>
</mjml>
Screenshot / GIF
Here's what the preview looks like during 20-30 sec :
And then images appear :
Specifications
- VS Code version: 1.33.1
- MJML extension version: 1.6.0
- Operating system and version: Windows 10 Build 17134
Works for me. Can not confirm this issue. Win 10.0.16299 Build 16299 VS Code 1.33.1 MJML extension 1.6.0