BTree icon indicating copy to clipboard operation
BTree copied to clipboard

NSFastEnumerationState is not supported By Linux

Open benoit-pereira-da-silva opened this issue 6 years ago • 5 comments

This fix suspends BridgedList's countByEnumerating func on Linux.

benoit-pereira-da-silva avatar Jan 19 '18 09:01 benoit-pereira-da-silva

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@8343537). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #30   +/-   ##
========================================
  Coverage          ?   8.16%           
========================================
  Files             ?      16           
  Lines             ?    4015           
  Branches          ?      43           
========================================
  Hits              ?     328           
  Misses            ?    3681           
  Partials          ?       6
Impacted Files Coverage Δ
Sources/BridgedList.swift 0% <ø> (ø)
Sources/List.swift 14.28% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8343537...2316b1a. Read the comment docs.

codecov[bot] avatar Jan 20 '18 18:01 codecov[bot]

@benoit-pereira-da-silva Thank you! Could you please remove the extra commits? Codable support should go in a separate PR.

lorentey avatar May 26 '18 12:05 lorentey

Sorry for hijacking this PR for asking this, but is the idea to keep compatibility with Linux or will that just be an after thought? Is there a CI that runs this in Linux as well to make sure it always works?

seivan avatar Jul 13 '18 12:07 seivan

Hi @seivan; I sent an invite with commit access. Thank you for volunteering to do this!

lorentey avatar Jul 13 '18 14:07 lorentey

@lorentey I Didn't, but I could look into it after seeing how Map performs compared to a Dictionary for my use-case on Linux.

seivan avatar Jul 13 '18 14:07 seivan