ast

ast copied to clipboard

Embedded command documentation needs to be moved outside the C source files

22

See issue #503 for an example where the information in `man ksh` differs from `some_command --help`. In that issue it is with respect to the `hist` command but there are...

krader1961

wcstoutf32s() is used exactly one place, has zero test coverage, and could be greatly simplified

2

The `wcstoutf32s()` function is used exactly one place, has zero test coverage, and could be greatly simplified based on that sole use. In fact, it looks like it can be...

krader1961

Builtin `sleep` and the `tmxdate()` function

8

Outside of the AST time subsystem there are relatively few uses of that code by ksh. One such use is the `tmxdate()` function. It is used in one place in...

krader1961

Why do so many functions return NULL if a memory allocation fails?

5

Please ponder why this function returns NULL if the memory allocation fails (from *src/cmd/ksh93/sh/nvdisc.c*): ``` static_fn void *newnode(const char *name) { size_t s; Namval_t *np = newof(0, Namval_t, 1, s...

krader1961

The `hash` command should be a builtin not an alias

1

While working on the `b_alias()` function to make it the first builtin to use `getopt_long()` rather than `optget()` I noticed it has a gross hack to support the bash `hash...

krader1961

The definition of `.` and `source` in `shtab_builtins[]` are different

7

While working on the conversion from the AST `optget()` function to the borg standard `getopt_long()` I noticed a weird discrepancy. The definitions of the `.` (dot) command and `source` in...

krader1961

First multi-byte character not being read correctly when run on the client side of a rlogin connection

11

On Solaris 11, ksh93 does not read the first multibyte character completely with rlogin(1). To reproduce: # rlogin XXX.XXX.XXX.XXX Password: Last login: Wed Aug 13 03:22:07 2019 from YYY.YYY.YYY.YYY Oracle...

rphaniram

functions fmtmatch() and fmtre() to convert between glob and ERE patterns are buggy

1

I recently added many more API tests of the `fmtre()` and `fmtmatch()` functions. Primarily to see if I could improve test coverage to acceptable levels. However, the API tests don't...

krader1961

While working on PR #1389 (Issue #570) I found there was one test that failed with that pull-request for no discernible reason: https://github.com/att/ast/blob/a9d4bb0064df247b20f604626b5b58698079bd4d/src/cmd/ksh93/tests/path.sh#L380-L391 The `PATH` var has to be modified...

krader1961

Test failure: subshell

4

The 'subshell' test fails on Gentoo Linux. [system-info.txt](https://github.com/att/ast/files/3563571/system-info.txt) ``` 268/287 subshell FAIL 1.03 s (exit status 1) --- command --- TEST_ROOT='/x/portage/app-shells/ksh-2020.0.0_beta1/work/ksh-2020.0.0-beta1/src/cmd/ksh93/tests' SHELL='/x/portage/app-shells/ksh-2020.0.0_beta1/work/ksh-2020.0.0_beta1-build/src/cmd/ksh93/ksh' LD_LIBRARY_PATH='/x/portage/app-shells/ksh-2020.0.0_beta1/work/ksh-2020.0.0_beta1-build/src/lib/libast:/x/portage/app-shells/ksh-2020.0.0_beta1/work/ksh-2020.0.0_beta1-build/src/lib/libcmd:/x/portage/app-shells/ksh-2020.0.0_beta1/work/ksh-2020.0.0_beta1-build/src/lib/libdll' LIBSAMPLE_PATH='/x/portage/app-shells/ksh-2020.0.0_beta1/work/ksh-2020.0.0_beta1-build/src/lib/libdll/libsample.so' SRC_ROOT='/x/portage/app-shells/ksh-2020.0.0_beta1/work/ksh-2020.0.0-beta1' /x/portage/app-shells/ksh-2020.0.0_beta1/work/ksh-2020.0.0_beta1-build/src/cmd/ksh93/ksh /x/portage/app-shells/ksh-2020.0.0_beta1/work/ksh-2020.0.0-beta1/src/cmd/ksh93/tests/util/run_test.sh subshell --- stdout...

floppym