atmosphere_pro icon indicating copy to clipboard operation
atmosphere_pro copied to clipboard

fix: #211 UI Redesign - Desktop - Settings

Open Chandram-Dutta opened this issue 2 years ago • 6 comments

- What I did Added new desktop background Added Settings Tab in sidebar Added Settings Screen Fixes #211

- How I did it Designed and Coded the settings screen for desktop and added it to navigation drawer following the convention of the app

- How to verify it Click on the setting tab in the sidebar

- Description for the changelog Added new Settings Screen

Chandram-Dutta avatar Oct 22 '22 19:10 Chandram-Dutta

Hey @tinashe404 This fixes #241

Chandram-Dutta avatar Oct 22 '22 19:10 Chandram-Dutta

@Chandram-Dutta This looks great! Only one suggestion! could you please resize the delete atsign modal so that it's around the same width as the backup keys one? Screenshot 2022-10-25 at 11 33 44 AM Screenshot 2022-10-25 at 11 33 52 AM

@sachins-geekyants or @nitesh2599 Please could you do a code review on this?

tinashe404 avatar Oct 25 '22 14:10 tinashe404

@Chandram-Dutta it looks like you worked on a ticket that wasn't assigned to you. This task is currently assigned to @AdiAr11

tinashe404 avatar Oct 25 '22 15:10 tinashe404

@Chandram-Dutta This looks great! Only one suggestion! could you please resize the delete atsign modal so that it's around the same width as the backup keys one? Screenshot 2022-10-25 at 11 33 44 AM Screenshot 2022-10-25 at 11 33 52 AM

@tinashe404 will do it...

Chandram-Dutta avatar Oct 27 '22 03:10 Chandram-Dutta

@Chandram-Dutta it looks like you worked on a ticket that wasn't assigned to you. This task is currently assigned to @AdiAr11

Yes, i did the mobile version and there were no followups on issue... So i used the codebase of the mobile to desktop...

Chandram-Dutta avatar Oct 27 '22 04:10 Chandram-Dutta

@Chandram-Dutta we accepted and merged your mobile PR for settings

tinashe404 avatar Oct 27 '22 15:10 tinashe404