atmosphere_pro icon indicating copy to clipboard operation
atmosphere_pro copied to clipboard

fix: #221 UI Redesign - Mobile - block atSign

Open tanmoy27112000 opened this issue 2 years ago • 6 comments

closes #221

- What I did I created the bottom sheet to show all the blocked atSign

- How I did it I created separate customisable widget and separate function for the bottom sheet

- How to verify it on welcome screen click on the welcome text to open the bottom sheet

- Description for the changelog Added blocked at Sign bottom sheet

tanmoy27112000 avatar Oct 07 '22 18:10 tanmoy27112000

@ksanty please review this PR. Thanks!!

tanmoy27112000 avatar Oct 08 '22 07:10 tanmoy27112000

Hi, just tried to check this and when I click on the welcome screen it produces this error message.

Screenshot 2022-10-12 at 1 15 33 PM

tinashe404 avatar Oct 12 '22 16:10 tinashe404

added the init function for sizeconfig now its working fine @tinashe404

tanmoy27112000 avatar Oct 12 '22 19:10 tanmoy27112000

@tanmoy27112000 The error message is still appearing.

tinashe404 avatar Oct 13 '22 14:10 tinashe404

Sorry fixed In wrong branch now working fine and verified. @tinashe404 Screenshot_1665776247

tanmoy27112000 avatar Oct 14 '22 19:10 tanmoy27112000

@tanmoy27112000 I've had a look. The UI looks good but there is no functionality implemented in it yet. Is this something you plan on doing?

The ideal PR would be one where

  • this screen/widget appears when you click on Blocked atSigns in the right hand menu
  • the close button closes this widget
  • the refresh button refreshes what is displayed on this widget
  • the widget displays the list of blocked atSigns (which is displayed on the current blocked atSigns screen, so you should just copy the functionality over)
  • clicking unblock, removes the atSign from the blocked list (as is done on the current blocked atSigns screen, so you should just copy the functionality over)
  • If you can't figure out how to search and sort we can leave this for now

tinashe404 avatar Oct 18 '22 13:10 tinashe404