atmosphere_pro icon indicating copy to clipboard operation
atmosphere_pro copied to clipboard

fix: #222 UI Redesign - Mobile - Trusted Senders

Open Becca-Saka opened this issue 2 years ago • 11 comments

- What I did Created a new UI design for the trusted senders screen and a remove trusted sender dialog which closes #222

- How I did it I created a new screen for the trusted senders screen inside the trusted contacts folder

- How to verify it add the code to the welcome screen and you should be able to click the button to view the new screen

 CustomOutlinedButton(
     buttonText: 'Trusted Senders',
      onPressed: () {
              showModalBottomSheet(
                  context: context,
                  elevation: 10,
                  isScrollControlled: true,
                  //color with gradient
                  barrierColor: Colors.white
                      .withOpacity(0.25)
                      .withOpacity(0.6),
                  shape: RoundedRectangleBorder(
                      borderRadius: BorderRadius.only(
                          topLeft:
                              Radius.circular(20.toWidth),
                          topRight:
                              Radius.circular(20.toWidth))),
                  builder: (context) => BackdropFilter(
                      filter: ImageFilter.blur(
                        sigmaY: -2,
                      ),
                      child: TrustedSenders()));
               },
    ),

- Description for the changelog Added trusted sender screen and dialog

Simulator Screen Shot - iPhone 11 Pro Max - 2022-10-03 at 15 57 57 Simulator Screen Shot - iPhone 11 Pro Max - 2022-10-03 at 15 57 54

Becca-Saka avatar Oct 03 '22 15:10 Becca-Saka

@Becca-Saka could you make it so this screen is shown when someone presses Trusted Senders on the menu that appears on the right?

tinashe404 avatar Oct 06 '22 14:10 tinashe404

Sure, I'll do that now

Becca-Saka avatar Oct 12 '22 09:10 Becca-Saka

Simulator Screen Shot - iPhone SE (3rd generation) - 2022-10-12 at 11 38 14

Does this work or should it be a full page? @tinashe404

Becca-Saka avatar Oct 12 '22 10:10 Becca-Saka

@Becca-Saka For now that will work. Make sure the code is already in the PR so that we don't need to add code in order to review.

tinashe404 avatar Oct 13 '22 15:10 tinashe404

@tinashe404 pushed my changes

Becca-Saka avatar Oct 13 '22 16:10 Becca-Saka

@Becca-Saka The screens look great. Do you plan on adding in the functionality that is currently implemented on the existing trusted senders screens.

You should be able to just copy it over so that

  • when you click Add atsign it shows the contacts screen... where people can add the trusted senders to the list
  • It displays actual contacts from the trusted senders list and not hard coded ones (Since most of them dont have pictures you can display a default image for all of them)
  • It shows the search filter as someone types in the search
  • clicking on a contact gives the option to remove them from the trusted senders list and clicking confirm removes them

This is all that is required for this issue and all the above functionality just needs to be copied over.

tinashe404 avatar Oct 18 '22 17:10 tinashe404

Hey, @tinashe404 Sorry for the late response. I made the changes

  1. Image functionality: I used the existing way to load the user's image, If it's empty it shows a placeholder

Simulator Screen Shot - iPhone 14 - 2022-10-30 at 09 44 08 Simulator Screen Shot - iPhone 14 - 2022-10-30 at 09 43 54

  1. It's possible for the nickname/name to be null so I am only showing the at sign in that situation

Simulator Screen Shot - iPhone 14 - 2022-10-30 at 09 42 34 Simulator Screen Shot - iPhone 14 - 2022-10-30 at 09 39 25

  1. Search function Simulator Screen Shot - iPhone 14 - 2022-10-30 at 10 03 51 Simulator Screen Shot - iPhone 14 - 2022-10-30 at 10 03 44

  2. removing trusted contacts

Simulator Screen Shot - iPhone 14 - 2022-10-30 at 10 12 27 Simulator Screen Shot - iPhone 14 - 2022-10-30 at 10 12 22

Becca-Saka avatar Oct 30 '22 09:10 Becca-Saka

@Becca-Saka This is awesome! @sachins-geekyants and @nitesh2599 please could you do a code review?

tinashe404 avatar Oct 31 '22 20:10 tinashe404

@tinashe404 The code looks fine to me. But, there are some conflicts.

nitesh2599 avatar Nov 02 '22 16:11 nitesh2599

@Becca-Saka Could you please resolve the conflicts in the above mentioned files?

nitesh2599 avatar Nov 03 '22 12:11 nitesh2599

@nitesh2599 Resolved the conflicts

Becca-Saka avatar Nov 16 '22 03:11 Becca-Saka