atmosphere_pro icon indicating copy to clipboard operation
atmosphere_pro copied to clipboard

UI Redesign - Mobile - FAQ's

Open ksanty opened this issue 2 years ago • 13 comments

Description The task is to implement the new design for the screens displayed on the FAQ navigation in the mobile app.

Assets and Design Screens All assets and design screens have already been created.

  • The Figma FAQ design can be found here
  • The Assets required can be found here 219.zip
  • Note this card is also associated with #220

Additional context

  • This work should be done on the UI_Redesign branch https://github.com/atsign-foundation/atmosphere_pro/tree/ui_redesign

ksanty avatar Sep 26 '22 20:09 ksanty

@ksanty I would like to work on this issue

tanmoy27112000 avatar Sep 29 '22 12:09 tanmoy27112000

I would like to work on this issue..., its my first time..can you guide me how do I send pull request?

ruqaiyasattar avatar Sep 29 '22 13:09 ruqaiyasattar

@ksanty I would like to work on this issue

Great! Let us know if you have any questions.

ksanty avatar Sep 29 '22 19:09 ksanty

I would like to work on this issue..., its my first time..can you guide me how do I send pull request?

Hi @ruqaiyasattar since it is just one screen and it looks like @tanmoy27112000 came in first, I've asked him to start. I'm checking to see about best approach to have you both work on it. @tinashe404 thoughts?

As for how to send a pull request, we have a template to use, which will pull up when you initiate the PR. Go ahead and respond to the questions in the template for any issues you are working on.

ksanty avatar Sep 29 '22 20:09 ksanty

@ruqaiyasattar and @tanmoy27112000 please both of you feel free to work on!! :-)

ksanty avatar Sep 29 '22 20:09 ksanty

@ksanty thanks

tanmoy27112000 avatar Sep 29 '22 21:09 tanmoy27112000

@tanmoy27112000 same with this the actual FAQ page is not present in the settings section. Please review this

tanmoy27112000 avatar Sep 30 '22 19:09 tanmoy27112000

@tanmoy27112000 this is for navigation buttons. Be sure to see the Design Systems page - https://www.figma.com/file/gnhrfcg8OYvAz0zJXZz2r3/Atmosphere-Pro?node-id=0%3A1.

@Dariamarg can help direct you to any code as she stated in her text message in Figma. image

ksanty avatar Oct 02 '22 02:10 ksanty

@ksanty thanks

tanmoy27112000 avatar Oct 02 '22 04:10 tanmoy27112000

I have created the screen but I have windows...i don't have an iPhone simulator to check... settings

ruqaiyasattar avatar Oct 06 '22 07:10 ruqaiyasattar

@ruqaiyasattar please create a PR and we will check.

tinashe404 avatar Oct 07 '22 14:10 tinashe404

Okay

On Fri, Oct 7, 2022, 7:06 PM Tinashe @.***> wrote:

@ruqaiyasattar https://github.com/ruqaiyasattar please create a PR and we will check.

— Reply to this email directly, view it on GitHub https://github.com/atsign-foundation/atmosphere_pro/issues/219#issuecomment-1271643786, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC7LJA3PWX3BLBGMGAGEOMTWCAU63ANCNFSM6AAAAAAQWFD5DQ . You are receiving this because you were mentioned.Message ID: @.***>

ruqaiyasattar avatar Oct 07 '22 14:10 ruqaiyasattar

@ksanty Can I work on it as the PR is not generated for it.

shwetavish avatar Oct 15 '22 10:10 shwetavish