atmosphere_pro icon indicating copy to clipboard operation
atmosphere_pro copied to clipboard

Published 20 hours ago • verified publisher icon atsign-foundation

Addition of + sign for contacts to be added in contact list in Atmosphere Pro Desktop

Open Pritam-deb opened this issue 2 years ago • 10 comments

Describe the bug In atmosphere pro desktop, when a contact shares a file with you, if that contact is not added to your contact's list, you should get a + icon on top of that contact, to add it to your contacts list.

To Reproduce

  1. Send a file from an unknown contact
  2. From the receiving end try to add the sender to your contact list

Expected behavior Users should be able to add the sender to contacts list.

Were you using an atApplication when the bug was found?

  • Atmosphere Pro Desktop

Pritam-deb avatar Sep 05 '22 10:09 Pritam-deb

@Pritam-deb what's the priority on this issue?

ksanty avatar Sep 06 '22 16:09 ksanty

Mid or low priority.

Pritam-deb avatar Sep 06 '22 16:09 Pritam-deb

PR: https://github.com/atsign-foundation/atmosphere_pro/pull/189

Pritam-deb avatar Sep 07 '22 04:09 Pritam-deb

@Pritam-deb

We have validated this feature with Atmosphere pro fix/add_unknown_contact branch on the below configuration. This feature is working as expected. However, we have observed that the clicking area of the "yes" and "no" buttons in add unknown contact widget is very large. PFA Screenshot for reference.

Screenshot 2022-09-07 at 3 52 38 pm

ayushkumarrojha avatar Sep 07 '22 10:09 ayushkumarrojha

@Pritam-deb

We have validated this feature with Atmosphere pro fix/add_unknown_contact branch on the below configuration. Adding unknown contacts from transfer history is working as expected.

Device Details: Device: MacBook Air OS: macOS Monterey 12.5

ayushkumarrojha avatar Sep 14 '22 04:09 ayushkumarrojha

@Pritam-deb

We have validated this feature with Atmosphere pro fix/add_unknown_contact branch on the below configuration. below issue is observed when we close the keyboard.

File_000

Device Details: Device: iPhone XR OS: iOS 15.6.1

ayushkumarrojha avatar Sep 14 '22 10:09 ayushkumarrojha

The fix have been added to the branch.

Pritam-deb avatar Sep 15 '22 08:09 Pritam-deb

@Pritam-deb

We have validated this feature with Atmosphere pro fix/add_unknown_contact branch on the below configuration. Adding unknown contacts from transfer history is working as expected.

Device Details: Device: MacBook Air OS: macOS Monterey 12.5

Device: iPhone XR OS: iOS 15.6.1

ayushkumarrojha avatar Sep 15 '22 12:09 ayushkumarrojha

Moving to requires validation.

sachins-geekyants avatar Sep 19 '22 13:09 sachins-geekyants

This is fixed

tinashe404 avatar Jan 03 '23 21:01 tinashe404