at_widgets icon indicating copy to clipboard operation
at_widgets copied to clipboard

Published 20 hours ago • verified publisher icon atsign-foundation

Switch themes for packages

Open sarika01 opened this issue 4 years ago • 12 comments

The Flutter widgets provided through pub.dev should have the ability to switch themes between light and dark, controlled by the implementing app.

  • [x] at_chat_flutter
  • [x] at_common_flutter
  • [x] at_contacts_flutter
  • [x] at_contacts_group_flutter
  • [x] at_events_flutter
  • [x] at_follows_flutter
  • [x] at_location_flutter
  • [x] at_onboarding_flutter
  • [x] at_backupkey_flutter

sarika01 avatar Aug 16 '21 06:08 sarika01

Each package needs to be tested and published.

sarika01 avatar Sep 07 '21 09:09 sarika01

Moving to backlog to give priority to other P1 issues. Current changes available on: https://github.com/atsign-foundation/at_widgets/tree/feature/switch-theme

sarika01 avatar Oct 04 '21 16:10 sarika01

@sonle-geekyants moving to high priority, so we can finish in PR43

ksanty avatar Jul 28 '22 01:07 ksanty

I’ve fixed it on branch feature/switch-theme-new in the at_widgets. @ayushkumarrojha, could you please test it?

sonle-geekyants avatar Aug 22 '22 07:08 sonle-geekyants

Needs validation and release. Moving to next sprint.

sachins-geekyants avatar Aug 22 '22 13:08 sachins-geekyants

@ayushkumarrojha can we test the packages for theme implementations ?

sachins-geekyants avatar Aug 29 '22 06:08 sachins-geekyants

@sonle-geekyants @sachins-geekyants

We have validated the switch themes feature with the atwidget feature/switch-theme-new branch, below issues are observed for the same:

Observations:

  1. Red screen appears in at_follows_flutter when we tab on the screen
  2. at_onboarding flutter is not getting build
  3. Error message appears when Start onboarding button is clicked on macOS
  4. Some buttons and text are not visible in the below-attached screenshots.

PFA Screenshots for reference. Switch new-20220906T060124Z-001.zip

Device Details: Device: iPhone XR OS: iOS 15.6

ayushkumarrojha avatar Sep 06 '22 06:09 ayushkumarrojha

Assigning 5 SP and moving to next sprint.

sachins-geekyants avatar Sep 06 '22 11:09 sachins-geekyants

Moving to requires validation.

sachins-geekyants avatar Sep 19 '22 12:09 sachins-geekyants

@sonle-geekyants @sachins-geekyants

We have validated the switch themes feature with the atwidget feature/switch-theme-new branch, below issues are observed for the same:

Observations:

  1. We are not able to build at_contacts_flutter and at_onboarding-flutter
  2. Pop-up box text is not visible in at_location flutter Screenshot 2022-10-04 at 12 55 56 pm

Device Details: Device: iPhone XR OS: iOS 15.6.1

ayushkumarrojha avatar Oct 04 '22 07:10 ayushkumarrojha

I have checked and I see that all issues are not occurring. Popup has changed theme color and I still build successfully at_contacts_flutter and at_onboarding_flutter on iOS. Could you please pull the newest code from branch "feature/switch-theme-new" and test it again? @ayushkumarrojha

https://user-images.githubusercontent.com/88494375/194253901-ff24b79a-5f64-42a1-9a6d-9357b6669318.mov

https://user-images.githubusercontent.com/88494375/194254794-8dd08b89-47c9-4595-bb2f-2ddc1f798ac1.mov

https://user-images.githubusercontent.com/88494375/194255503-c6fc4d58-d353-4229-9ad3-7fd86d3e3b95.mov

sonle-geekyants avatar Oct 06 '22 08:10 sonle-geekyants

@sonle-geekyants @sachins-geekyants

We have validated the switch themes feature with the atwidget feature/switch-theme-new branch, below issue is observed for the same:

Observations:

  1. Text is not displayed in Group Name text box while creating a new group in at_contacts_group_flutter File_000 (6)

Device Details: Device: iPhone XR OS: iOS 15.6.1

ayushkumarrojha avatar Oct 14 '22 11:10 ayushkumarrojha