at_server icon indicating copy to clipboard operation
at_server copied to clipboard

at_server's implementation of OutboundMessageListener is lagging at_lookup's

Open gkc opened this issue 3 years ago • 1 comments

Describe the bug

  • at_server has its own implementation of OutboundMessageListener. This contains old code which doesn't include the fixes that have been made in AtLookup which properly handle slow network connections where the full server response might not be received before timeout. While this is unlikely to happen when the communicating secondaries are running in the same GCP region, it is a lot more likely to happen when secondaries are running in places we can't predict.

Expected behaviour

  • at_secondary_server/lib/src/connection/outbound/outbound_message_listener.dart should be compared with old versions of the same class in at_lookup
  • Assuming same semantics, at_secondary_server's implementation should be removed and we use at_lookup's improved implementation instead
  • We should also refactor e2e_test_utils.dart in at_server/at_end2end_test to use the improved code

gkc avatar Oct 02 '22 17:10 gkc

Moving to backlog but changing to High priority so we don't forget about it

gkc avatar Nov 13 '22 14:11 gkc