at_server icon indicating copy to clipboard operation
at_server copied to clipboard

Functional Tests with config change

Open purnimavenkatasubbu opened this issue 2 years ago • 12 comments

Is your feature request related to a problem? Please describe. Add tests for the features that need a server config change.

  • [x] Connection limit test
  • [x] Assert behavior of compaction and other scheduled or triggered jobs - Compaction Stats
  • [ ] Timeout tests

This is equivalent to #505

purnimavenkatasubbu avatar Mar 07 '22 06:03 purnimavenkatasubbu

Currently, the timeouts in the server are hardcoded in the code for a default value. Hence the functional tests cannot be written around these at the moment.

purnimavenkatasubbu avatar Mar 21 '22 05:03 purnimavenkatasubbu

We need ability - in test environments only initially - to dynamically adjust server config from an authenticated client. Filed https://github.com/atsign-foundation/at_server/issues/588

gkc avatar Mar 21 '22 14:03 gkc

The tests for connection limit, compaction, and access logs are pushed to the branch issue#542.

This needs a config change in the server for the tests to pass.

purnimavenkatasubbu avatar Mar 30 '22 15:03 purnimavenkatasubbu

@gkc I need a secondary config change (for instance inbound_connection_limit set to 2, compactionJobRun set to 1minute) for the tests to pass in the GitHub Actions. Can we pass a sed command in the GitHub actions before running the tests that need a config change? sed 's/inbound_max_limit: 50/inbound_max_limit: 1/' col | tee config/config.yaml

Or is there any better way to do this?

purnimavenkatasubbu avatar Apr 05 '22 06:04 purnimavenkatasubbu

This task is dependent on #588 to adjust the config changes for the test atsigns. Hence no progress was made in this sprint.

purnimavenkatasubbu avatar May 02 '22 05:05 purnimavenkatasubbu

moving this to backlog till #588 is done

murali-shris avatar May 03 '22 10:05 murali-shris

@purnimavenkatasubbu Can you specify precisely which parameters need to be dynamically configurable right now please? Is it just inbound_connection_limit and compactionJobRun?

gkc avatar May 03 '22 15:05 gkc

Yes, @gkc. I need to set inbound_connection_limit and compactionJobRun before the test run and reset it to the default value after the test completion.

purnimavenkatasubbu avatar May 04 '22 05:05 purnimavenkatasubbu

@purnimavenkatasubbu should this be moved to high priority, so we can work and close in PR43/44?

ksanty avatar Jul 29 '22 19:07 ksanty

It's just about done, it's been worked On steadily for the past few weeks

gkc avatar Jul 29 '22 19:07 gkc

It's just about done, it's been worked On steadily for the past few weeks

Should it be in PR42 as unplanned work?

ksanty avatar Jul 29 '22 19:07 ksanty

Maybe? Purnima have you been active on this in the current sprint?

gkc avatar Jul 29 '22 20:07 gkc