at_server icon indicating copy to clipboard operation
at_server copied to clipboard

Uptake persistence refactoring in at_server

Open murali-shris opened this issue 1 year ago • 9 comments

Is your feature request related to a problem? Please describe.

Uptake the changes done in https://github.com/atsign-foundation/at_server/issues/1788

Describe the solution you'd like

Replace calls to put/create with new params

Describe alternatives you've considered

No response

Additional context

No response

murali-shris avatar Feb 20 '24 10:02 murali-shris

Code changes done in https://github.com/atsign-foundation/at_server/tree/uptake_persistence_refactoring One of the tests related to setting metadata to null string (update_verb_test.dart) is failing. Investigating the issue.

murali-shris avatar Feb 20 '24 10:02 murali-shris

PRs raised and review done. https://github.com/atsign-foundation/at_server/pull/1813 https://github.com/atsign-foundation/at_server/pull/1822 Will review adding more tests and merge the PRs once uptake on client side/app testing is done with new server changes

murali-shris avatar Mar 04 '24 11:03 murali-shris

blocked on failing end2end test in at_client https://github.com/atsign-foundation/at_client_sdk/pull/1255

murali-shris avatar Mar 18 '24 09:03 murali-shris

blocked on failing end2end test in at_client atsign-foundation/at_client_sdk#1255

Issue fixed https://github.com/atsign-foundation/at_client_sdk/pull/1275

murali-shris avatar Apr 02 '24 08:04 murali-shris

  • Resolved test failures, raised separate PRs for persistence and server Pending
  • test apps with server changes

murali-shris avatar Jun 10 '24 10:06 murali-shris

Test Scenarios Execution Report

Server-Side

  1. Created New Keys with Metadata:

    • Using the current branch of the server, I successfully created new keys and populated all available metadata fields.
  2. Updated Existing Key Metadata:

    • I modified the metadata of an existing key using the current branch of the server.
  3. Switched Branch and Verified Metadata:

    • I switched to the trunk branch of the server and utilized the same storage to verify the consistency of the metadata.
    • I again updated the existing metadata and confirmed that the changes were correctly reflected.
  4. Created Additional Keys with Metadata:

    • Using the trunk branch, I created new keys and populated them with metadata.

Client-Side

  1. Updated Keys with Trunk Branch:

    • Using the trunk branch of at_client, I updated several keys and verified the updates with the current trunk branch of the server.
  2. Cross-Branch Compatibility and Data Verification:

    • I switched to the current branch of the server and used the trunk branch of at_client with the same hive storage.
    • I confirmed that the existing data was accessible and verified that new data updates were correctly applied.

purnimavenkatasubbu avatar Jul 19 '24 12:07 purnimavenkatasubbu

Test Scenarios Execution Report

Server-Side

  1. Created New Keys with Metadata:

    • Using the current branch of the server, I successfully created new keys and populated all available metadata fields.
  2. Updated Existing Key Metadata:

    • I modified the metadata of an existing key using the current branch of the server.
  3. Switched Branch and Verified Metadata:

    • I switched to the trunk branch of the server and utilized the same storage to verify the consistency of the metadata.
    • I again updated the existing metadata and confirmed that the changes were correctly reflected.
  4. Created Additional Keys with Metadata:

    • Using the trunk branch, I created new keys and populated them with metadata.

Client-Side

  1. Updated Keys with Trunk Branch:

    • Using the trunk branch of at_client, I updated several keys and verified the updates with the current trunk branch of the server.
  2. Cross-Branch Compatibility and Data Verification:

    • I switched to the current branch of the server and used the trunk branch of at_client with the same hive storage.
    • I confirmed that the existing data was accessible and verified that new data updates were correctly applied.

@purnimavenkatasubbu Client side scenario 2. did you update existing metadata after upgrading to trunk branch ? for both scenarios..did you check adding of new metadata and deletion of existing metadata?

murali-shris avatar Jul 23 '24 05:07 murali-shris

Test Scenarios Execution Report

Server-Side

  1. Created New Keys with Metadata:

    • Using the current branch of the server, I successfully created new keys and populated all available metadata fields.
  2. Updated Existing Key Metadata:

    • I modified the metadata of an existing key using the current branch of the server.
  3. Switched Branch and Verified Metadata:

    • I switched to the trunk branch of the server and utilized the same storage to verify the consistency of the metadata.
    • I again updated the existing metadata and confirmed that the changes were correctly reflected.
  4. Created Additional Keys with Metadata:

    • Using the trunk branch, I created new keys and populated them with metadata.

Client-Side

  1. Updated Keys with Trunk Branch:

    • Using the trunk branch of at_client, I updated several keys and verified the updates with the current trunk branch of the server.
  2. Cross-Branch Compatibility and Data Verification:

    • I switched to the current branch of the server and used the trunk branch of at_client with the same hive storage.
    • I confirmed that the existing data was accessible and verified that new data updates were correctly applied.

@purnimavenkatasubbu Client side scenario 2. did you update existing metadata after upgrading to trunk branch ? for both scenarios..did you check adding of new metadata and deletion of existing metadata?

Verified the following scenarios

  1. Updated existing metadata after upgrading to trunk , I was able to update the existing metadata successfully
  2. Deletion of existing metadata is not possible. We can only update the metadata.

For an existing metadata, Say existing ttr = 1000, Updated ttr =null. But it's still 1000 as its value.

purnimavenkatasubbu avatar Jul 24 '24 09:07 purnimavenkatasubbu

moving to backlog

murali-shris avatar Aug 05 '24 10:08 murali-shris