at_client_sdk icon indicating copy to clipboard operation
at_client_sdk copied to clipboard

Published 20 hours ago • verified publisher icon atsign-foundation

fix: getAtSign return null

Open sonle-geekyants opened this issue 3 years ago • 2 comments

- What I did Fix this minor issue #656

- How I did it Have a mistake in return condition of getAtSign in KeychainManager. I corrected it.

- How to verify it Check the code change and verify in the app

- Description for the changelog

sonle-geekyants avatar Aug 19 '22 06:08 sonle-geekyants

@sachins-geekyants could you please merge and release a new version for this?

sonle-geekyants avatar Sep 06 '22 09:09 sonle-geekyants

It does work for me in mobile currently I'm using this change for atBuzz.

yahu1031 avatar Sep 14 '22 08:09 yahu1031

@sonle-geekyants @sachins-geekyants Why was this never merged? Is there still a bug here?

gkc avatar Feb 09 '23 21:02 gkc

@gkc This used to work sometimes. Not sure why but when I use a debugger, It used to work fine, else it gives me null data. Maybe somewhere an await was missing or something, but before it gets the value, it is getting returned. I tested this branch during that time. My comment from above was during some scenarios and I thought it was working and then later it doesn't. We had a call regarding this. And later never heard about it.

  • This info may help for cross-checking things. Regards 😄

yahu1031 avatar Feb 10 '23 06:02 yahu1031

It should have been merged but somehow got missed. @sonle-geekyants can you check if this PR is still relevant and resolves the conflict?

sachins-geekyants avatar Feb 10 '23 10:02 sachins-geekyants

Yes, I've checked it, please merge it. @sachins-geekyants

sonle-geekyants avatar Feb 10 '23 14:02 sonle-geekyants