at_client_sdk icon indicating copy to clipboard operation
at_client_sdk copied to clipboard

authenticate returns true for invalid atKeys file

Open sachins-geekyants opened this issue 3 years ago • 1 comments

Describe the bug If we reset an atSign and activate it again we will have a new atKeys file and old atkeys file will become invalid. AtClientService.authenticate returns true for old atkeys file as well.

To Reproduce Steps to reproduce the behavior:

  1. activate an atSign and get the atKeys file.
  2. reset the atSign.
  3. activate again and get new atKeys file.
  4. If we upload old atKeys file to authenticate it returns true.

Expected behavior AtClientService.authenticate should return false for invalid atKeys.

Smartphone (please complete the following information):

  • macOS

Were you using an @‎application when the bug was found?

  • atmospherePro

sachins-geekyants avatar Aug 03 '22 11:08 sachins-geekyants

Possible that the old keys are being synched from an old client ?

cconstab avatar Aug 08 '22 16:08 cconstab

Fixed the issue and the changes are available in https://github.com/atsign-foundation/at_client_sdk/pull/666. Request the apps team/QA team to test the changes. The changes are available in fix_auth_issue in at_client_sdk repo.

sitaram-kalluri avatar Aug 29 '22 02:08 sitaram-kalluri

@kalluriramkumar With the shared at_client branch, the issue is not reproducibile.

sachins-geekyants avatar Aug 29 '22 12:08 sachins-geekyants

@kalluriramkumar With the shared at_client branch, the issue is not reproducibile.

@sachins-geekyants : Great, Can you please confirm the regression tests are also covered?

sitaram-kalluri avatar Aug 29 '22 12:08 sitaram-kalluri

@sachins-geekyants

This issue is not reproducible with atmosphere pro invalid-atkey branch on the below configurations:

Device Details: Device: iPhone XR OS: iOS 15.6

ayushkumarrojha avatar Aug 30 '22 13:08 ayushkumarrojha

The changes are published in at_client_mobile : 3.2.5

sitaram-kalluri avatar Sep 01 '22 11:09 sitaram-kalluri