at_client_sdk
at_client_sdk copied to clipboard
authenticate returns true for invalid atKeys file
Describe the bug
If we reset an atSign and activate it again we will have a new atKeys file and old atkeys file will become invalid.
AtClientService.authenticate returns true for old atkeys file as well.
To Reproduce Steps to reproduce the behavior:
- activate an atSign and get the atKeys file.
- reset the atSign.
- activate again and get new atKeys file.
- If we upload old atKeys file to authenticate it returns
true.
Expected behavior
AtClientService.authenticate should return false for invalid atKeys.
Smartphone (please complete the following information):
- macOS
Were you using an @application when the bug was found?
- atmospherePro
Possible that the old keys are being synched from an old client ?
Fixed the issue and the changes are available in https://github.com/atsign-foundation/at_client_sdk/pull/666. Request the apps team/QA team to test the changes. The changes are available in fix_auth_issue in at_client_sdk repo.
@kalluriramkumar With the shared at_client branch, the issue is not reproducibile.
@kalluriramkumar With the shared at_client branch, the issue is not reproducibile.
@sachins-geekyants : Great, Can you please confirm the regression tests are also covered?
@sachins-geekyants
This issue is not reproducible with atmosphere pro invalid-atkey branch on the below configurations:
Device Details: Device: iPhone XR OS: iOS 15.6
The changes are published in at_client_mobile : 3.2.5