atsamd icon indicating copy to clipboard operation
atsamd copied to clipboard

hal: Switch from custom time traits to `embedded_time`

Open twitchyliquid64 opened this issue 4 years ago • 4 comments

WIP

Anyone got a thumbv7-based board they can test the timers/pwm on to make sure the new divider calcuations are correct?

twitchyliquid64 avatar Nov 07 '20 00:11 twitchyliquid64

Took a look. PWM (tc4 tcc0) pygamer looked consistent. But timer tc3 panics

18:51:35.272 panicked at 'internal error: entered unreachable code',
/home/jacob/Downloads/atsamd/hal/src/common/thumbv7em/timer.rs:107:22

I havent dug in further yet

jacobrosenthal avatar Nov 20 '20 01:11 jacobrosenthal

embedded-time got some nice cleanups after rtic started implementing it . Might be worth another look

jacobrosenthal avatar Jun 21 '21 22:06 jacobrosenthal

there's also now fugit which I like (it's a lot simpler), but it doesn't have the Hz()/kHz()/etc. helpers AFAIK.

TDHolmes avatar Jan 11 '22 21:01 TDHolmes

Latest release fugit v0.3.5 added support for Hz, kHz etc :D

AfoHT avatar Feb 16 '22 06:02 AfoHT

Closed via #672.

jbeaurivage avatar May 29 '23 16:05 jbeaurivage