Anton Troynikov
Anton Troynikov
@levand let's put time on the calendar to review in person
@levand let's find time to review in person
Happy to make the necessary changes on our end!
@nablabits do you still plan to wrap this up? Is it currently ready for review?
Great, thank you! Let me review changes from here and we can get this landed.
In the meantime if you have the stomach for it, this might be a great follow-up https://github.com/chroma-core/chroma/issues/2128
@tazarov this PR is intended to make landing those other ones (and future ones) easier, and since they are purely additive it's a simple change which we can do ourselves...
@nablabits will be landing this week!
We are good to merge! I made a few more changes: - the top-level `embedding_functions` module now dynamically imports anything that's a sub-class of `EmbeddingFunction` from any file in the...
My changes broke on python versions 3.9, 3.10 - reverting and fixing.