clj-sockets icon indicating copy to clipboard operation
clj-sockets copied to clipboard

Eliminate use of core.typed?

Open mfikes opened this issue 7 years ago • 1 comments

The use of core.typed in clj-sockets caused some sort of AoT-related failure (see CLJS-2742) that can be worked around by having clients use the non-AoT version of ClojureScript 1.10.238 (via the :classifier "slim").

Downstream, Tubular is working around this by simply using a copy of clj-sockets that doesn't use this dependency.

I was curious if you'd be interested in having this change in clj-sockets itself (the removal of core.typed). If so, I'd be willing to put together a PR for consideration.

mfikes avatar Apr 27 '18 11:04 mfikes

Or would something like this work?

https://github.com/marick/lein-midje/pull/69/files

I see this error:

$ lein run
WARNING: boolean? already refers to: #'clojure.core/boolean? in namespace: clojure.core.typed.contract-utils, being replaced by: #'clojure.core.typed.contract-utils/boolean?

EdwardIII avatar Jul 01 '21 19:07 EdwardIII