deep-text-corrector icon indicating copy to clipboard operation
deep-text-corrector copied to clipboard

Cannot replicate

Open rajivpoddar opened this issue 8 years ago • 15 comments

I trained the model as specified in the readme but cannot replicate the results. The following is what I get.

Input: you must have girlfriend Output: than than than than than than than than than than

Is this because of the training/dataset?

rajivpoddar avatar Feb 28 '17 08:02 rajivpoddar

hi @braindead i have problem in training it show error

batched_corrective_tokens = tf.pack(
AttributeError: 'module' object has no attribute 'pack'

in file

text_corrector_models.py line 91

tensorflow V 1.0.0

essamgoda avatar Mar 13 '17 21:03 essamgoda

@braindead I also get this kind of results. Have you solved it? @essamgoda You should use stack instead of pack.

xushenkun avatar Mar 22 '17 05:03 xushenkun

another error show

@xushenkun

TypeError: Input 'y' of 'Mul' Op has type float32 that does not match type int32 of argument 'x'.

essamgoda avatar Mar 23 '17 11:03 essamgoda

@essamgoda Maybe change labels and inputs, as in in API https://www.tensorflow.org/versions/r1.1/api_docs/python/tf/nn/sampled_softmax_loss def sampled_loss(labels, inputs): labels = tf.reshape(labels, [-1, 1]) return tf.nn.sampled_softmax_loss(w_t, b, labels, inputs, num_samples, self.target_vocab_size)

another error "Ran out of memory"

File "correct_text.py", line 434, in main
   train(data_reader, FLAGS.train_path, FLAGS.val_path, FLAGS.model_path)
 File "correct_text.py", line 181, in train
   target_weights, bucket_id, False)
 File "text_corrector_models.py", line 297, in step
   outputs = session.run(output_feed, input_feed)

Command used: python correct_text.py --train_path "./data/movie_dialog_train.txt" --val_path "./data/movie_dialog_val.txt" --config DefaultMovieDialogConfig --data_reader_type MovieDialogReader --model_path "./movie_dialog_model"

Used data and source code: https://www.dropbox.com/s/oo7e9vg5hcrnjke/deep-text-corrector-master.rar?dl=0

derofim avatar Mar 29 '17 21:03 derofim

@derofim thanks alot it's worked

your code worked (take a long time)

try to reduce number of layer and size if your resource is limited i use gpu ( Nvidia 940 mx 4 gb)

essamgoda avatar Mar 31 '17 15:03 essamgoda

@braindead @xushenkun the same error did you solve it ?

essamgoda avatar Mar 31 '17 15:03 essamgoda

@essamgoda hi, how much steps have you trained? when I run 20000 times in half an hour, it showed....

Input: you must have girlfriend Output: girlfriend girlfriend girlfriend girlfriend girlfriend girlfriend girlfriend girlfriend girlfriend girlfriend

liuyichaosoftware avatar Apr 13 '17 13:04 liuyichaosoftware

@liuyichaosoftware I also run 20000 times

essamgoda avatar Apr 16 '17 09:04 essamgoda

Same here.

bittlingmayer avatar May 04 '17 22:05 bittlingmayer

@braindead @essamgoda I am having the same issues with the model. Did you eventually solve it? Or is it unsolvable?

HarshdeepGupta avatar May 30 '17 10:05 HarshdeepGupta

Problem fixed. Please see my fork.

qinbill avatar Oct 01 '17 10:10 qinbill

@braindead @essamgoda @HarshdeepGupta I have the same kind of output here:

na na na na na na na na na na
what what what what what what what what what what
gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim gim
... ... ... ... ... ... ... ... ... ...
up up up up up up up up up up
ya ya ya ya ya ya ya ya ya ya ya ya ya ya ya

I didnt change parameters. I also run 20000 times. Did anyone eventually manage to get expected results?

arianpasquali avatar Jan 26 '18 21:01 arianpasquali

@qinbill what exactly did you fixed? did you get expected results?

arianpasquali avatar Jan 26 '18 22:01 arianpasquali

how to get expected results, and which parameters should change? output: what what what what what what what what what

shibing624 avatar Apr 26 '18 06:04 shibing624

Problem fixed. Please see my fork.

Hi, which problem did you fix? problem 'cannot replicate the results'? I tried your fork with my pertained model but still get the same kind of results.

Baidi96 avatar Apr 06 '19 08:04 Baidi96