Coluna.jl icon indicating copy to clipboard operation
Coluna.jl copied to clipboard

Follow up of "custom data"

Open guimarqu opened this issue 4 years ago • 0 comments

  • [x] Create a AbstractCustomData type to make clear what is the super type of the field custom_data in Variable & Constraint & also the type of custom_data in some methods.

  • [x] Create methods addcustomconstrs!(blockmodel, custom_data_type) & addcustomvars!(blockmodel, custom_data_type) in BlockDecomposition & call methods Coluna.MathProg.addcustomconstrs! when we create the master formulation. Then, we can remove : https://github.com/atoptima/Coluna.jl/blob/36e2d0d8f40ba964637c1d6da8b0683ffd776f08/test/custom_var_cuts_tests.jl#L79-L82 and https://github.com/atoptima/Coluna.jl/blob/36e2d0d8f40ba964637c1d6da8b0683ffd776f08/test/custom_var_cuts_tests.jl#L138-L141

  • [x] Move the following method in BlockDecomposition. Check if we can untype all arguments. https://github.com/atoptima/Coluna.jl/blob/36e2d0d8f40ba964637c1d6da8b0683ffd776f08/test/custom_var_cuts_tests.jl#L35-L37

  • [x] Move the following methods in BlockDecomposition : https://github.com/atoptima/Coluna.jl/blob/36e2d0d8f40ba964637c1d6da8b0683ffd776f08/test/custom_var_cuts_tests.jl#L29-L34

  • [x] Create new methods in MathProg to set/get current inc_val and get perene inc_val of a constraint. Then, update the following pieces of code : https://github.com/atoptima/Coluna.jl/blob/36e2d0d8f40ba964637c1d6da8b0683ffd776f08/test/custom_var_cuts_tests.jl#L94 https://github.com/atoptima/Coluna.jl/blob/36e2d0d8f40ba964637c1d6da8b0683ffd776f08/src/Algorithm/colgen.jl#L367-L373 Hint for docstring :

[22:00] Artur Pessoa: A constraint is a variable in the dual. So, it seems natural to me that the incumbent value of the constraint is the dual value associated to it.

  • [ ] Change the output when we separate cuts with custom data ?

Robust cut separation callback adds 0 new essential cuts and 1 new facultative cuts.

  • [ ] Documentation

guimarqu avatar Jun 04 '21 17:06 guimarqu