conditional-flow-matching icon indicating copy to clipboard operation
conditional-flow-matching copied to clipboard

Published 20 hours ago • verified publisher icon atong01

Unused `num_images` param in cifar10 example

Open QB3 opened this issue 1 year ago • 1 comments

The parameter num_images is currently unused in the cifar10 example https://github.com/atong01/conditional-flow-matching/blob/21cd0c888186f6e2b76deb393800361b8a850e9b/examples/cifar10/train_cifar10.py#L52

It would be great to have a generate_cifar10.py to generate a given number of images, as in the edm code https://github.com/NVlabs/edm

QB3 avatar Nov 13 '23 17:11 QB3

Hello,

Thank you for noticing this unused variable. This will be removed in a future PR.

Regarding the generate_cifar10.py, I agree it is a good idea. I will add it to the to-do list.

kilianFatras avatar Nov 14 '23 16:11 kilianFatras