tippyjs icon indicating copy to clipboard operation
tippyjs copied to clipboard

refactor(types): decrease specificity of lifecycle hook return type

Open J-Michalek opened this issue 9 months ago • 0 comments

I find it oddly specific and since I am using https://typescript-eslint.io/rules/explicit-function-return-type/ in my projects I have to explicitely say false | void instead of a simple boolean with it every time there is a tooltip that should have a onShow hook condition. Passing true should work the same as void as the implementation only checks for false.

const showTooltip = false

// There has to be a condition to satisfy the void return type
function onShow(): false | void {
  if (!showTooltip) {
    return false
  }
}

// Ideally this would work
function onShow(): boolean {
  return showTooltip
}

J-Michalek avatar May 27 '24 19:05 J-Michalek