hyperdex icon indicating copy to clipboard operation
hyperdex copied to clipboard

Published 20 hours ago • verified publisher icon atomiclabs

The DEX needs a logout button

Open ptyx11 opened this issue 6 years ago • 9 comments

HyperDEX Nightly 0.0.0-570351d-18.5.13.937 Electron 2.0.0 darwin 17.5.0 Locale: en-US

ptyx11 avatar May 14 '18 10:05 ptyx11

You can log out from the HyperDEX (macOS) / File (Linux/Window) menu.

sindresorhus avatar May 14 '18 10:05 sindresorhus

@sindresorhus We probably should make this easier to access. Maybe clicking the avatar in the top right corner should open a drop down menu. That seems like the intuitive place to look.

Not vital for the 0.1.0 milestone but we should do this at some point.

lukechilds avatar May 14 '18 11:05 lukechilds

@lukechilds I don't agree. This is a native app, not a web app. We should use the native menus for things like this.

Here are how some other native apps do it:

screen shot 2018-05-14 at 18 34 24 screen shot 2018-05-14 at 18 40 50 screen shot 2018-05-14 at 18 41 36 screen shot 2018-05-14 at 18 42 04

sindresorhus avatar May 14 '18 11:05 sindresorhus

An easy to use Logout button to use another profile isn't going to kill anyone. Just place it in the corner like most apps. This is about user friendliness.

ptyx11 avatar May 14 '18 11:05 ptyx11

Just place it in the corner like most apps.

What native apps? I'm just curious as I've never seen it done in the UI in native apps.

sindresorhus avatar May 14 '18 11:05 sindresorhus

We could make it more obvious by putting it in the Portfolio menu, like this:

screen shot 2018-05-14 at 18 53 53

sindresorhus avatar May 14 '18 11:05 sindresorhus

I like adding it to a portfolio menu.

And just to counter your point, I think it's slightly different in our case. In those other apps you mentioned users aren't likely to be switching accounts very often. The user accounts are more for a subscription model so once they're logged in it's likely to stay that way, probably forever.

However portfolios are a fundamental part of our app, logging in/out is likely to occur much more often. And if you compare to an app like Spotify, which has a similar kind of UI design to us, and also will be more likely to have multiple users to log in/out, they do have an in app login button in the corner.

screen shot 2018-05-14 at 6 59 30 pm

lukechilds avatar May 14 '18 12:05 lukechilds

I'm happy to go with whatever you decide @lukechilds, but I still don't agree it's any easier or more obvious to click the avatar and then "Log Out" than it is to click the "Portfolio" menu and then "Log Out". Exact same amount of clicks and mouse movement and I would even argue the system menu is more obvious as it's text instead of behind an avatar icon.

sindresorhus avatar May 14 '18 12:05 sindresorhus

My assumptuon is that in this case slightly more users will intuitively search for the logout at the corner dropdown.

But why not offer this option at both places?

norbertdragan avatar May 15 '18 12:05 norbertdragan