atomic-server icon indicating copy to clipboard operation
atomic-server copied to clipboard

Cleaned multi-thread -200ms improvement, within noise threshold

Open AlexMikhalev opened this issue 3 years ago • 3 comments

Signed-off-by: Alex Mikhalev [email protected]

This is multi-threaded all_resources instead of https://github.com/joepio/atomic-data-rust/pull/394/

AlexMikhalev avatar Apr 22 '22 22:04 AlexMikhalev

Great, thanks! Try running cargo fmt and cargo clippy to fix various linting / error usage errors. Should auto-fix most of them.

joepio avatar Apr 23 '22 14:04 joepio

Looks like some tests are failing

joepio avatar Apr 23 '22 20:04 joepio

Strange, coverage test needs fix in dependencies - llvm missing, another works on my mac:

cargo test db::test::populate_collections --all-features
warning: /Users/alexmikhalev/rust_code/atomic-data-rust/lib/Cargo.toml: unused manifest key: bench.0.all-features
warning: /Users/alexmikhalev/rust_code/atomic-data-rust/server/Cargo.toml: dependency (sysinfo) specified without providing a local path, Git repository, or version to use. This will be considered an error in future versions
warning: /Users/alexmikhalev/rust_code/atomic-data-rust/server/Cargo.toml: unused manifest key: dependencies.sysinfo.sysinfo
   Compiling atomic_lib v0.31.1 (/Users/alexmikhalev/rust_code/atomic-data-rust/lib)
warning: unused `Result` that must be used
   --> lib/src/db.rs:495:17
    |
495 |                 send.send(process_resource(item));
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(unused_must_use)]` on by default
    = note: this `Result` may be an `Err` variant, which should be handled

warning: `atomic_lib` (lib test) generated 1 warning
    Finished test [unoptimized + debuginfo] target(s) in 9.72s
     Running unittests (/Users/alexmikhalev/rust_code/atomic-data-rust/target/debug/deps/atomic_lib-f38d07b8edfc95f2)

running 1 test
test db::test::populate_collections ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 62 filtered out; finished in 4.89s

AlexMikhalev avatar Apr 24 '22 11:04 AlexMikhalev