settings-view
settings-view copied to clipboard
Update status message should not count disabled packages
Moved from https://github.com/atom/settings-view/issues/955
Disabled packages should not be counted (
(N) Updates
message at the bottom-right corner)
Hey, I'm a new developer trying to resolve this issue and I have some questions. I've been looking at two different types of solutions and I wanted to ask here to see what you think.
- If the disabled packages are not counted in the
package-updates-status-view
then it should resolve this issue with some work. - The other solution is by not adding disabled packages to
updatablePackages
insidepackage-manager
this would result in that you only see your active packages in the Available Updates panel.
Do you want to see that disabled packages have updates? Do we want to update disabled packages when pressing update all?
@JonatanPaalsson
Do you want to see that disabled packages have updates?
Yes, but not as visible as enabled packages. Disabled packages should be hidden behind an expand button.
Do we want to update disabled packages when pressing update all?
Normally, "Update All" will only update enabled packages, unless user click the expand button, "Update All" will update all.
I just made a pull request to fix this. It does not have any specs yet, but other than that, I think it will solve this bug.
Normally, "Update All" will only update enabled packages, unless user click the expand button, "Update All" will update all.
Maybe an "Update Active Packages"-button could be added as a separate feature?
@JonatanPaalsson makes sense
@KSXGitHub I'd be happy to give it a shot if new issue is created