settings-view icon indicating copy to clipboard operation
settings-view copied to clipboard

Update status message should not count disabled packages

Open KSXGitHub opened this issue 7 years ago • 6 comments

Moved from https://github.com/atom/settings-view/issues/955

Disabled packages should not be counted ((N) Updates message at the bottom-right corner)

KSXGitHub avatar May 25 '17 16:05 KSXGitHub

Hey, I'm a new developer trying to resolve this issue and I have some questions. I've been looking at two different types of solutions and I wanted to ask here to see what you think.

  1. If the disabled packages are not counted in the package-updates-status-view then it should resolve this issue with some work.
  2. The other solution is by not adding disabled packages to updatablePackagesinside package-manager this would result in that you only see your active packages in the Available Updates panel.

Do you want to see that disabled packages have updates? Do we want to update disabled packages when pressing update all?

JonatanPaalsson avatar Sep 28 '17 22:09 JonatanPaalsson

@JonatanPaalsson

Do you want to see that disabled packages have updates?

Yes, but not as visible as enabled packages. Disabled packages should be hidden behind an expand button.

Do we want to update disabled packages when pressing update all?

Normally, "Update All" will only update enabled packages, unless user click the expand button, "Update All" will update all.

KSXGitHub avatar Sep 29 '17 03:09 KSXGitHub

I just made a pull request to fix this. It does not have any specs yet, but other than that, I think it will solve this bug.

JonatanPaalsson avatar Oct 03 '17 12:10 JonatanPaalsson

Normally, "Update All" will only update enabled packages, unless user click the expand button, "Update All" will update all.

Maybe an "Update Active Packages"-button could be added as a separate feature?

JonatanPaalsson avatar Oct 10 '17 18:10 JonatanPaalsson

@JonatanPaalsson makes sense

KSXGitHub avatar Oct 11 '17 05:10 KSXGitHub

@KSXGitHub I'd be happy to give it a shot if new issue is created

JonatanPaalsson avatar Oct 11 '17 06:10 JonatanPaalsson