settings-view
settings-view copied to clipboard
New Pane is not auto focused
Prerequisites
- [X] Put an X between the brackets on this line if you have done all of the following:
- Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
- Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
- Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
- Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
- Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages
Description
When using the keyboard command to install a package the new pane does not autofocus to the input. Requires using the mouse to select the search field. Keyboard bindings should keep us at the keyboard for faster productivity.
Steps to Reproduce
- CMD+SHIFT+P
- Choose the action Install Package
Expected behavior:
The opened pane window should be focused
Actual behavior:
Open pane window does not autofocus
Reproduces how often:
100%
Versions
Atom : 1.49.0 Electron: 5.0.13 Chrome : 73.0.3683.121 Node : 12.0.0 apm 2.5.0 npm 6.14.5 node 10.20.1 x64 atom 1.49.0 python 2.7.16 git 2.24.3
This issue should probably be moved to atom/settings-view as it's the relevant package.
I found an old but simular issue regarding keybindings instead of install packages atom/settings-view issue 1083
EDIT:
Looks like
focus
is already being called, so not sure why it doesn't work. I tried adding asetTimeout
and it works, so I suspect a race condition.
Originally posted by @gosukiwi in https://github.com/atom/settings-view/issues/1083#issuecomment-703050204