"Featured Packages" is showing featured themes as well

[Arcanemagus]

Prerequisites

• [X] Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

The list of Featured Themes is being added to the list of Featured Packages.

Steps to Reproduce

1. Open Atom in Safe Mode
2. Go to Settings -> Install
3. Look at the list of Featured Packages

Expected behavior:

Only packages show in the Featured Packages.

Actual behavior:

Themes are showing in the package list:

Reproduces how often:

100% of the time.

Versions

OS: Windows 10 x64

Atom    : 1.34.0-nightly8
Electron: 2.0.12
Chrome  : 61.0.3163.100
Node    : 8.9.3
apm  2.1.3
npm  6.2.0
node 8.9.3 x64
atom 1.34.0-nightly8
python 2.7.15
git 2.19.1.windows.1
visual studio 2015

Additional Information

Looks like this is the inverse of https://github.com/atom/settings-view/issues/304.

[winstliu]

:+1: from me on adding a --packages argument to apm and simply propagating that flag in settings-view rather than trying to filter out themes.