node-keytar icon indicating copy to clipboard operation
node-keytar copied to clipboard

change xcode_settings in binding.gyp for universal macOs build

Open poisonReact opened this issue 3 years ago • 4 comments

🍎

  • makes node.keytar work on arm64 and x86 architecture

poisonReact avatar Sep 15 '21 08:09 poisonReact

Recommend against this, this will double the binary size. I have two separate builds for x64 and arm64 and only include the .node for the target arch.

kaatt avatar Sep 16 '21 13:09 kaatt

Recommend against this, this will double the binary size. I have two separate builds for x64 and arm64 and only include the .node for the target arch.

we are specially build a universal version for macOs application so as not to confuse users

poisonReact avatar Sep 16 '21 13:09 poisonReact

Looking forward to this one!

maccman avatar Sep 22 '21 18:09 maccman

Only way for us to use keytar on a universal build was to use this pull request in combination with buildDependenciesFromSource in the electron-builder file

Using the prebuilt adds a keytar.node to the asar file that is not universal Using the pull request correctly adds a universal keytar.node

benoist avatar Jan 16 '22 18:01 benoist