language-typescript icon indicating copy to clipboard operation
language-typescript copied to clipboard

NoSubstitutionTemplateLiteral breaks coloring

Open ericbf opened this issue 5 years ago • 1 comments

Prerequisites

  • [x] Put an X between the brackets on this line if you have done all of the following:
    • Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
    • Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
    • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
    • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
    • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

When using NoSubstitutionTemplateLiterals as types it breaks coloring.

Steps to Reproduce

type literal = {
	normal: "string"
	hello: `hello`
	world: `world`
	exclamation: `!`
	another: `!`
}

Expected behavior: [What you expect to happen]

Text is colored correctly.

Actual behavior: [What actually happens]

Screen Shot 2019-04-03 at 10 42 06 AM

Edit by @rsese to add additional screenshot with 1.37.0-nightly32 on macOS 10.12.6:

hello-value

And with Tree-sitter disabled:

hello-value-ts-disabled

Reproduces how often: [What percentage of the time does it reproduce?]

Always.

Versions

electron 2.0.18 chrome 61.0.3163.100 apm 2.1.3 npm 6.2.0 node 8.9.3 x64 atom 1.35.1 python 2.7.16 git 2.20.1 language-typescript 0.4.11 macos 10.14.4

ericbf avatar Apr 03 '19 14:04 ericbf

Thanks for the report! Noting what I see at the hello value with 1.37.0-nightly32 on macOS 10.12.6:

hello-value

And with Tree-sitter disabled:

hello-value-ts-disabled

rsese avatar Apr 12 '19 01:04 rsese