language-ruby icon indicating copy to clipboard operation
language-ruby copied to clipboard

YARD comments no longer syntax highlighted

Open ioquatix opened this issue 7 years ago • 11 comments

Prerequisites

  • [ ] Put an X between the brackets on this line if you have done all of the following:
    • Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
    • Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
    • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
    • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
    • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

YARD comments no longer syntax highlighted

Steps to Reproduce

Previously, comments would be highlighted:

# @return [String] The result
def foobar
  return "foobar"
end

Expected behavior:

@return would be highlighted, along with other parts of the structured comment.

Actual behavior:

It's not highlighted

Reproduces how often: 100%

Versions

1.32.0

ioquatix avatar Oct 26 '18 00:10 ioquatix

cc @madleech

ioquatix avatar Oct 26 '18 00:10 ioquatix

Here is an example of what it used to look like:

https://github.com/atom/language-ruby/issues/228

ioquatix avatar Oct 26 '18 00:10 ioquatix

Can you please update this issue to follow the template? Thanks!

Arcanemagus avatar Oct 29 '18 16:10 Arcanemagus

@Arcanemagus Okay, done. What more information do you need?

ioquatix avatar Oct 29 '18 19:10 ioquatix

It looks like this is a regression from the enabling of Tree-sitter parsers by default in Atom v1.32.0:

Text-mate: image

Tree-sitter: image

You can work around this for now by changing the Settings -> Core -> Use Tree-sitter Parsers option within the Settings app.

Arcanemagus avatar Oct 29 '18 20:10 Arcanemagus

Ah so maybe a bug with the new parser? or a bug with how the grammar is specified?

ioquatix avatar Oct 29 '18 20:10 ioquatix

From what I can see that extension simply hasn't been implemented in the Tree-sitter parser.

Arcanemagus avatar Oct 29 '18 20:10 Arcanemagus

That makes sense. Should we file a bug report on the tree-sitter parser?

ioquatix avatar Oct 29 '18 20:10 ioquatix

That makes sense. Should we file a bug report on the tree-sitter parser?

Just here is fine 😉.

Arcanemagus avatar Oct 29 '18 20:10 Arcanemagus

It looks like the same issue may have also broken the language-todo package.

Before: screen shot 2018-10-30 at 10 10 38 pm

After: screen shot 2018-10-30 at 10 10 50 pm

epaulet avatar Oct 31 '18 05:10 epaulet

@epaulet That is being tracked in https://github.com/atom/language-todo/issues/82 and https://github.com/atom/atom/issues/18196. You may want to subscribe to those issues for updates.

Arcanemagus avatar Oct 31 '18 06:10 Arcanemagus