language-ruby icon indicating copy to clipboard operation
language-ruby copied to clipboard

ERB files grammar is not correct

Open deiga opened this issue 7 years ago • 0 comments

Prerequisites

  • [X] Put an X between the brackets on this line if you have done all of the following:
    • Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
    • Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
    • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
    • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
    • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

PR #181 introduced a very subtle bug, which can't be reproduced other than in a very controller environment

Steps to Reproduce

  1. Disable package language-ruby-on-rails
  2. Reload editor
  3. Open a file with a plain .erb extension
  4. Set syntax to Auto Detect

Expected behavior: File syntax should be Ruby or Embedded Ruby or something and scope should be source.ruby.embedded or something

Actual behavior: Syntax is Plain Text and scope is text.plain.null-grammar

Reproduces how often:

100%

Versions

Atom: 1.18.0 Electron: 1.3.15 apm: 1.18.1 macOS 10.12.5

Additional Information

It seems that removing erb from HTML (Ruby - ERB) grammar left a hole where there is no actual grammar for .erb files defined

deiga avatar Jun 25 '17 18:06 deiga