ide-php icon indicating copy to clipboard operation
ide-php copied to clipboard

FelixFBecker keeps initializing

Open Jamie-Vandenbalck opened this issue 5 years ago • 8 comments

Description

FelixFBecker keeps initializing. I uninstalled and reinstalled php-ide but problem still occurs. FelixFBecker just keeps initializing infinite.

Reproduces how often:

This only occurs in my Symfony projects.

Versions

MacOs version: v11.1

Atom version: Atom: 1.53.0 Electron: 6.1.12 Chrome: 76.0.3809.146 Node: 12.4.0

PHP Version: v7.4.13

ide-php version: v0.7.18

Jamie-Vandenbalck avatar Dec 16 '20 14:12 Jamie-Vandenbalck

Same on OpenSUSE Leap 15.3 & PHP 7.4.6, Atom 1.52.0 x64.

I've found out that maximum PHP version supported is 7.3.9.

boogiefromzk avatar Jan 11 '21 13:01 boogiefromzk

When using older PHP version it works indeed. I couldn't find anywhere details about the supported php versions, they should mention it.

Jamie-Vandenbalck avatar Jan 11 '21 13:01 Jamie-Vandenbalck

You shouldn't have closed it :) it's PHP 8 released already :)

boogiefromzk avatar Jan 11 '21 13:01 boogiefromzk

Ah yes :)

Jamie-Vandenbalck avatar Jan 11 '21 13:01 Jamie-Vandenbalck

I haven't tested with PHP8, but for PHP7.4 the quickest/easiest solution for this problem is to ensure php.ini for the CLI is set to NOT output errors for use of deprecated functions.

In other words, users with this problem probably have error_reporting set to E_ALL in php.ini. Changing it to : error_reporting = E_ALL & ~E_DEPRECATED & ~E_STRICT and restarting Atom should resolve the problem (it did for me). Preferable to downgrading PHP to 7.3.

I believe a permanent fix is being sought here in the upstream code: https://github.com/felixfbecker/php-advanced-json-rpc/issues. It's probably a trivial change, but beyond my abilities.

redcuillin avatar Mar 13 '21 06:03 redcuillin

I haven't tested with PHP8, but for PHP7.4 the quickest/easiest solution for this problem is to ensure php.ini for the CLI is set to NOT output errors for use of deprecated functions.

In other words, users with this problem probably have error_reporting set to E_ALL in php.ini. Changing it to : error_reporting = E_ALL & ~E_DEPRECATED & ~E_STRICT and restarting Atom should resolve the problem (it did for me). Preferable to downgrading PHP to 7.3.

I believe a permanent fix is being sought here in the upstream code: https://github.com/felixfbecker/php-advanced-json-rpc/issues. It's probably a trivial change, but beyond my abilities.

This fix worked for me, ditched PHP 8 to go back to PHP 7.4. I am hopeful about a fix and this language server being updated for 8, but nothing for 2 years from Felix.

Peytoria avatar Jun 22 '21 15:06 Peytoria

I've been able to reliably reproduce this.

  1. With a fresh Atom profile (mv ~/.atom ~/.atom-backup)
  2. Install these packages: apm install atom-ide-ui ide-php linter
  3. Start Atom. (This will install busy-signal, intentions, linter-ui-default.)
  4. Choose "Disable Linter" in the prompt
    Screen-shotScreenshot_2021-07-12_15-16-42
  5. From now on, every PHP file opened will result in a new PHP Language Server being started.

The following error can be seen on the JavaScript console within Atom:

~/.atom/packages/ide-php/node_modules/atom-languageclient/build/lib/server-manager.js:5 Uncaught (in promise) Error: Emitter has been disposed
    at Emitter.on (/usr/share/atom/resources/app/static/<embedded>:11)
    at yt.onDidDestroy (~/.atom/packages/linter/dist/index.js:1)
    at LinterPushV2Adapter.attach (~/.atom/packages/ide-php/node_modules/atom-languageclient/build/lib/adapters/linter-push-v2-adapter.js:28)
    at PHPLanguageClient.startExclusiveAdapters (~/.atom/packages/ide-php/node_modules/atom-languageclient/build/lib/auto-languageclient.js:362)
    at PHPLanguageClient.<anonymous> (~/.atom/packages/ide-php/node_modules/atom-languageclient/build/lib/auto-languageclient.js:298)
    at Generator.next (<anonymous>)
    at fulfilled (~/.atom/packages/ide-php/node_modules/atom-languageclient/build/lib/auto-languageclient.js:4)

I've worked around this by disabling the "Diagnostics" feature within atom-ide-ui.

fredden avatar Jul 12 '21 14:07 fredden

I haven't tested with PHP8, but for PHP7.4 the quickest/easiest solution for this problem is to ensure php.ini for the CLI is set to NOT output errors for use of deprecated functions.

In other words, users with this problem probably have error_reporting set to E_ALL in php.ini. Changing it to : error_reporting = E_ALL & ~E_DEPRECATED & ~E_STRICT and restarting Atom should resolve the problem (it did for me). Preferable to downgrading PHP to 7.3.

Tried using php8.0, I can confirm this workaround don't work. It's sad to see that I'm not able to try this plugin just because it uses deprecated functions...

LoganTann avatar Jul 18 '21 23:07 LoganTann