github icon indicating copy to clipboard operation
github copied to clipboard

Explicitly set contextIsolation to false

Open bongnv opened this issue 3 years ago • 0 comments

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

Description of the Change

Since Electron 12, the default of contextIsolation is changed to true from false so we'll have to set it to false. Otherwise, Node APIs won't be used in renderer processes.

See https://github.com/electron/electron/issues/23506 for more information.

Screenshot or Gif

N/A

Applicable Issues

N/A

bongnv avatar Oct 07 '22 00:10 bongnv