github icon indicating copy to clipboard operation
github copied to clipboard

[WIP] don't call method of destroyed webContents

Open icecream17 opened this issue 2 years ago • 2 comments

Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

Description of the Change

The ubuntu tests have been failing, even for perfectly valid prs

One of the complained errors says "Attempting to call a function in a renderer window that has been closed or released." EDIT: This appears in all the tests, so this error (or warning?) doesn't actually fail the tests

So I think this attempt removes the function call - and hopefully fixes the tests

Screenshot or Gif

image

Applicable Issues

icecream17 avatar Oct 21 '21 18:10 icecream17

Codecov Report

Merging #2722 (c9ecdfe) into master (2053290) will increase coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2722      +/-   ##
==========================================
+ Coverage   93.46%   93.47%   +0.01%     
==========================================
  Files         237      237              
  Lines       13213    13213              
  Branches     1900     1900              
==========================================
+ Hits        12349    12351       +2     
+ Misses        864      862       -2     
Impacted Files Coverage Δ
lib/git-shell-out-strategy.js 100.00% <0.00%> (+0.18%) :arrow_up:
lib/atom/gutter.js 92.85% <0.00%> (+2.38%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2053290...c9ecdfe. Read the comment docs.

codecov[bot] avatar Oct 21 '21 18:10 codecov[bot]

Okay, everything still seems to be the same....

icecream17 avatar Oct 21 '21 18:10 icecream17