github icon indicating copy to clipboard operation
github copied to clipboard

How Enterprise?

Open BinaryMuse opened this issue 8 years ago • 18 comments

At minimum we'll need to wait till the GraphQL API is available there, but we're also constantly adding fields to GitHub.com's codebase to account for our API use case — so how can we reliably support Enterprise sooner rather than later?

BinaryMuse avatar Oct 05 '16 17:10 BinaryMuse

"How Enterprise?" indeed.

By which I mean, can I use this on GHE.io? I tried pulling/pushing and ⚛️ just looked at me grumpily.

ThirdEyeRose avatar Jan 11 '17 22:01 ThirdEyeRose

@that-pat Hm, interesting — this issue was actually referring to the GitHub integration portion of the package. The Git integration is not GitHub specific, so it should just work. Did you get any sort of error or anything?

BinaryMuse avatar Jan 12 '17 00:01 BinaryMuse

@that-pat In particular, can you open the dev console (cmd-option-i) and then try to push and pull? You'll likely see git error messages, including stderr and such, which would be super helpful.

smashwilson avatar Jan 12 '17 00:01 smashwilson

Absolutely. Here's the error that I get through the Atom interface: screen shot 2017-01-12 at 8 15 27 am

And here are the only errors in the dev console: screen shot 2017-01-12 at 8 17 26 am

When I do a fetch instead of a push or pull, it asks me for a username and a password and then does nothing.

These operations do work with the Git Plus Atom plugin which I had disabled for my initial tests and then re-enabled and tried again with the same results.

ThirdEyeRose avatar Jan 12 '17 14:01 ThirdEyeRose

For information, GitHub Enterprise 2.10.0 has just been released, with support for GraphQL API.

Usage of GraphQL API through GitHub Enterprise is documented here.

chickenkiller avatar Jun 06 '17 08:06 chickenkiller

While this release of Enterprise supports GraphQL, the GitHub integration part of this package is still in progress and we're still adding fields to GitHub.com's GraphQL API as we need them, and these new fields will take some amount of time to make it to an Enterprise release.

In an ideal world, we could do some sort of feature detection and use different "versions" of the integration depending on which versions of the GraphQL API are available, but this is something we haven't yet talked about so I don't have any immediate plans to share. It is on my mind, however!

BinaryMuse avatar Jun 12 '17 17:06 BinaryMuse

Since 5 months have passed I thought to ask... Is there any update to share on the status of this? :)

quasipedia avatar Nov 03 '17 11:11 quasipedia

This follow up is from April 2018.

dotku avatar Apr 18 '18 00:04 dotku

This is a kind of a deal breaker between for using VisualStudio over Atom. @BinaryMuse, is there any realistic plan to do this?

ungarida avatar Jun 17 '18 07:06 ungarida

It's been over a year since GHE started supporting graphql in the API - an update would be nice; has there been any progress towards this?

tsal avatar Jul 03 '18 14:07 tsal

💀 waiting for github enterprise support 💀

jjnich avatar Oct 10 '18 19:10 jjnich

This is a much needed feature. Can someone please get this going?

sidx64 avatar Nov 20 '18 20:11 sidx64

So, your bot says that at GitHub, you treat your issues as your backlog.... but then you mark each comment from your users who bring your attention to this as "spam"? I don't get it, my product owner would die to have spontaneous input from our users that would inform him about what users deem important for them...

Is there any any other way we should use to let you know what is important for us?

quasipedia avatar Dec 12 '18 11:12 quasipedia

@quasipedia You can use emoji reactions on the original post to upvote it if you want to let us know that this is something that is important to you. The reason why we minimize these comments as off-topic or spam is because they do nothing to move the issue toward completion. When an issue bubbles to the top and we go to look for people giving us helpful information such as debug logs, steps to reproduce the problem, or other helpful information, having to scroll through bunches of "is this done yet?" makes our job take longer. If you would like to give direct input to the team on your thoughts about prioritization, you can email us at [email protected].

lee-dohm avatar Dec 12 '18 17:12 lee-dohm

is this still in progress?

sri321 avatar Feb 15 '19 12:02 sri321

I wonder if this is still really open? Trying to find a solution for using GitHub Enterprise with Atom.

mstaragrieb avatar Dec 09 '20 21:12 mstaragrieb

I spent a few days looking for what I was doing wrong b/c I was unable to get github enterprise linked to ATOM, it never crossed my mind that it was not possible...... This is a huge ding vs Atom. Most of my work, is done for a company where everything is via GH enterprise. I guess I'll add my +1, but considering how long this has been open, I see a different editor happening sooner.

A bit of advice- I encourage you to call out in the docs that you do not, infact, support GH enterprise and save a whole lot of people wasted time.

iamh2o avatar Nov 19 '21 04:11 iamh2o

+1 to integration with Github enterprise! I like Atom a lot and integration with GH enterprise would be a great feature. I also agree it would be good to advertise more clearly that the integration isn't available in the meantime.

Leebre avatar Apr 12 '22 13:04 Leebre