Feature proposal: Editable Diff

[vanessayuenn]

This is a work-in-progress feature proposal, started off as a summary of the discussion in #1720. As I did more research and thought more about the execution, however, I realized making a unified diff view editable is quite a bit more challenging than originally anticipated. That probably is why there's no prior art of similar implementation to be found in the wild (all of the editable diff tool uses the split view approach which is covered in this proposal 😄)!

A chat with @simurai this morning has inspired a slightly different direction, which is what this RFC is proposing. I have included the first iteration as well in "Rationale and alternatives" section for the record. The last few sections are TBD at the moment but will be filled out as discussions unfold.

---

View rendered docs/feature-requests/005-editable-diff.md

[codecov[bot]]

Codecov Report

Merging #1882 into master will increase coverage by 0.04%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1882      +/-   ##
==========================================
+ Coverage   92.91%   92.95%   +0.04%     
==========================================
  Files         219      219              
  Lines       12570    12570              
  Branches     1798     1798              
==========================================
+ Hits        11679    11685       +6     
+ Misses        891      885       -6     

Impacted Files	Coverage Δ
lib/git-shell-out-strategy.js	99.80% <0.00%> (+0.19%)	:arrow_up:
lib/shared/keytar-strategy.js	58.13% <0.00%> (+0.77%)	:arrow_up:
lib/models/workspace-change-observer.js	97.02% <0.00%> (+3.96%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f175ae9...161667f. Read the comment docs.